fix extension editor components #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahil Shubham <[email protected]>
WD-1223 [BUG] Editor components render behind sputlit
Describe the bugAll the editor components render behind the template, it's not just an issue of z-index but now that the whole extension is in a shadow dom, the styled component root is inside the shadow root. Resulting in not only the editor components being behind the sputlit but also not inheriting anything from theme. Expected BehaviourThe editor components should render and work properly. The editor components include:
ScreenshotsIf applicable Additional ContextAny additional things that might help gain context of the bug |
Signed-off-by: Sahil Shubham <[email protected]>
sahil-shubham
changed the title
Signed-off-by: Sahil Shubham <[email protected]>
manavagr1108
pushed a commit
that referenced
this pull request
Jun 20, 2022
#66 * passed styleSlot as balloon toolbar portal element; Signed-off-by: Sahil Shubham <[email protected]> * WIP editor components appear on top now; but wrong position; Signed-off-by: Sahil Shubham <[email protected]> * mex-editor v0.5.0; Signed-off-by: Sahil Shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
styleSlotdiv inside shadow domISSUE
Signed-off-by: Sahil Shubham [email protected]