Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] New UI for Alias and Tags #433

Merged
merged 8 commits into from
Jun 8, 2023
Merged

Conversation

sahil-shubham
Copy link
Member

@sahil-shubham sahil-shubham commented Jun 5, 2023

In this PR

  • Moved to @use-gesture/react for handling mouse events on drag toggle
  • Added new animation for buttons which appear when hovering on drag toggle
  • Add inline input for making alias
    • Different icon if the link is already shortened
  • Add bounds to the toggle also while accommodating the height of the buttons below
  • Add appropriate tooltips

Testing

  • Tested dragging and persisting of toggle (EDIT: not going ahead with layout store persistent because it also ends up persisting the sidebar expanded boolean. Considering moving the toggle a one time thing on a tab)
  • Tested url shortening

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023

🦋 Changeset detected

Latest commit: 5c83d65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mexit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@use-gesture/core ADDED - 10.2.27
@use-gesture/react ADDED - 10.2.27
react-use-hoverintent REMOVED 1.2.9 -

@sahil-shubham sahil-shubham marked this pull request as ready for review June 7, 2023 14:26
@sahil-shubham sahil-shubham changed the title [WIP] New UI for Alias and Tags [TASK] New UI for Alias and Tags Jun 7, 2023
@dineshsingh1 dineshsingh1 merged commit 6682968 into main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants