Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in Notes and Meta data store #304

Merged
merged 12 commits into from
Dec 12, 2022

Conversation

dineshsingh1
Copy link
Member

@dineshsingh1 dineshsingh1 commented Dec 12, 2022

Icon Picker and Metadata Store

  • Use MIcon with types in Note Hierarchy, Extension, Combobox, Previews, ..etc.
  • useMetadataStore added for storing metadata for Note, Snippet and Namespace.
  • All components using content for extracting metadata from note are now using useMetadataStore.
  • In Editor toolbar, Icon picker added for Note.
  • Add updateMetadata API added for updating metadata of Notes and Snippets. Set Template now uses this endpoint to change templateID for child notes instead of calling saveDataAPI.

Screenshot

Screenshot 2022-12-12 at 10 31 20 PM

@dineshsingh1 dineshsingh1 marked this pull request as draft December 12, 2022 16:58
@linear
Copy link

linear bot commented Dec 12, 2022

WD-1737 [TASK] Note Icons with Icon Picker

Description

A brief description of the task

  • Add Note Icons support in web app.
  • Add Icon picker on Note's header component.
  • Update Icon types in Tree, Combobox, extension and Lookup .

Purpose

What is the purpose of this task?

  • UI improvements.

Additional Context

Any additional information that needs to be added

@dineshsingh1 dineshsingh1 requested a review from rpPanda December 12, 2022 17:02
@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2022

🦋 Changeset detected

Latest commit: 3605d05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mexit Patch
mexit-webapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dineshsingh1 dineshsingh1 marked this pull request as ready for review December 12, 2022 17:43
@dineshsingh1 dineshsingh1 force-pushed the dinesh-wd-1737-task-note-icons-with-icon-picker branch from f2274ee to 2d43b50 Compare December 12, 2022 18:39
@mukul-mehta mukul-mehta self-requested a review December 12, 2022 19:42
@mukul-mehta mukul-mehta merged commit e7107af into main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants