-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons in Notes and Meta data store #304
Merged
mukul-mehta
merged 12 commits into
main
from
dinesh-wd-1737-task-note-icons-with-icon-picker
Dec 12, 2022
Merged
Icons in Notes and Meta data store #304
mukul-mehta
merged 12 commits into
main
from
dinesh-wd-1737-task-note-icons-with-icon-picker
Dec 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WD-1737 [TASK] Note Icons with Icon Picker
DescriptionA brief description of the task
PurposeWhat is the purpose of this task?
Any additional information that needs to be added |
🦋 Changeset detectedLatest commit: 3605d05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f2274ee
to
2d43b50
Compare
mukul-mehta
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icon Picker and Metadata Store
MIcon
with types inNote Hierarchy
,Extension
,Combobox
,Previews
, ..etc.useMetadataStore
added for storing metadata forNote
,Snippet
andNamespace
.useMetadataStore
.Editor
toolbar,Icon picker
added for Note.updateMetadata
API added for updating metadata ofNotes
andSnippets
.Set Template
now uses this endpoint to changetemplateID
for child notes instead of callingsaveDataAPI
.Screenshot