Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug bashing #293

Merged
merged 12 commits into from
Dec 2, 2022
Merged

Bug bashing #293

merged 12 commits into from
Dec 2, 2022

Conversation

sahil-shubham
Copy link
Member

@sahil-shubham sahil-shubham commented Dec 2, 2022

In this PR

  • fixed image CDN upload from webapp
  • updated background of iframe rendered actions to that of extension for seamless look
  • displayed shortcut for commenting
  • updated message for when no shared notes
  • fixed todo status in public nodes
  • fixed builds post Common ESLint config; Code Improvements #292 Shared Note User Response Fixed #294
  • added build test action so that the above doesn't happen again
  • fixed referenceID for creating quick notes (notes weren't going in Drafts hierarchy
  • made some changes towards consistent font and other sizes in extension sidebar

@linear
Copy link

linear bot commented Dec 2, 2022

WD-1727 [BUG] Bug bashing

Describe the bug

Fix bugs found in testing during testing post highlight entity and vite in extension, bugs listed down in https://mexit.workduck.io/share/NODE_qhciV4U3XPV7Np48yFFVD

Additional Context

Any additional things that might help gain context of the bug

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2022

🦋 Changeset detected

Latest commit: 78266d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mexit Patch
mexit-webapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sahil-shubham sahil-shubham force-pushed the sahil-shubham-wd-1727-bug-bug-bashing branch from 9aa969b to 154ce8c Compare December 2, 2022 15:11
@sahil-shubham sahil-shubham force-pushed the sahil-shubham-wd-1727-bug-bug-bashing branch from 154ce8c to fdb66db Compare December 2, 2022 15:39
@dineshsingh1 dineshsingh1 merged commit b312a10 into main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants