Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight Entity #284

Merged
merged 29 commits into from
Nov 28, 2022
Merged

Conversation

xypnox
Copy link
Contributor

@xypnox xypnox commented Nov 17, 2022

Todo

  • HighlightAPI
    • Sync with backend
    • Sync stores
  • Handle highlight calls from extension
    • Move requests of highlight to background script
  • HighlightTypes
  • HighlightStore
  • HighlightMetadata Transformation
  • HighlightBlockMap generation
  • Highlight Hooks
  • Adapt usage of web-highlighter to new format
    • Change dataHighlightId(blockid) to highlightID from entity
  • Tooltip
    • Delete Highlight
    • Edit Highlight?
      • Where
  • Sidebar
  • Save link on highlight
    • Link requires title?
  • Use blockid delete from backend
  • Remove old code
  • [-] Use append to add highlight to node
    Doesn't really matter as append endpoint doesn't return all the data so it is always added to the present content only

Highlights user flows

  • Select a block of text on a page and highlight the content
    • Saves content in blocks in a given note
    • Creates highlight entity and associates the blocks with entity (vice versa)
  • Show highlights of a URL in the sidebar
    • Also shown in the links view
    • Fetch all blocks from highlightid to render content correctly
  • Deleting a highlight
    • Get all blocks (with noteids) that are associated with the highlight
    • Delete them (remove from content)
  • Interactions in editor
    • Moving highlight to a different note
      • Changes will be made in the highlightBlockMap
    • Deleting the highlighted block [:?]
      • Previously this used to remove highlight as well as it was in the metadata
        • Should we remove highlight when no blocks remain of that highlightID?

@linear
Copy link

linear bot commented Nov 17, 2022

WD-1704 [TASK] Highlight entity frontend

Description

Move highlights from block metadata to a separate entity with stores and use entityId in block metadata to represent highlight groups.

Insert captured content as separate blocks rather than wrapped in a single block with metadata.

Show highlight sourceURL correctly by hiding on blocks that follow block with highlight URL

Purpose

Highlights split Highlights get better

Additional Context

Any additional information that needs to be added

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022

🦋 Changeset detected

Latest commit: b85994f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mexit Patch
mexit-webapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xypnox xypnox force-pushed the xypnox-wd-1704-task-highlight-entity-frontend branch from 9cdd360 to c336b44 Compare November 19, 2022 16:01
@xypnox xypnox force-pushed the xypnox-wd-1704-task-highlight-entity-frontend branch from 50c138c to a94c128 Compare November 26, 2022 16:51
@xypnox xypnox marked this pull request as ready for review November 28, 2022 11:38
@rpPanda rpPanda merged commit dd088cb into main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants