Bug fixes combo/link/reminders bugs #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xypnox
commented
Nov 10, 2022
xypnox
commented
- Fix create new behaviour for combobox elements other than ilinks
- Fix url deletion request url
- Fix reminder view link and id to a constant
Conditionally checks the presence of the current namespace in items if only the command is internal, i.e. [[
WD-1685 [BUG] Extension combo/link bugs
Describe the bug
Expected BehaviourExplain what was supposed to happen
ScreenshotsSlack https://workduck-workspace.slack.com/archives/C049CHKV8U9/p1667838396217099 https://workduck-workspace.slack.com/archives/C049CHKV8U9/p1667840835155009 Additional ContextNA |
🦋 Changeset detectedLatest commit: 2a0763f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
xypnox
requested review from
rpPanda and
mukul-mehta
and removed request for
rpPanda
rpPanda
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.