Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate tree, spaces and tabs in sidebar using Shortcuts #248

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

dineshsingh1
Copy link
Member

Better Navigation

In Non-editable mode:

  • Navigate tree using Option + Up/Down shortcuts.
  • Navigate spaces using Option + Left/Right shortcuts.
  • Navigate tabs in RightSidebar in extension using Command + / shortcut.
    • Right Sidebar tree Items are now managed by useRightSidebarItems hook. Use this modify state of right sidebar.
    • Shortcut listener is added in useRightSidebarShortcuts hook.

Fixes

  • On double click, focus on editable previews.

Video

Screen.Recording.2022-11-04.at.2.15.31.AM.mov

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2022

🦋 Changeset detected

Latest commit: 2d8b608

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mexit Patch
mexit-webapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linear
Copy link

linear bot commented Nov 3, 2022

WD-1676 [TASK] Tree and Space Navigation using shortcuts

Description

A brief description of the task

When in Non Editable mode,

  • On Option + Left/Right switch between namespaces
  • On `Option + Up/Down navigate between Notes in hierarchy.
  • Right sidebar extension navigate between tabs using CMD+/. after it's enabled.
  • Navigate in browser history in Notes route.

Some Fixes that has been added in this repo:

  • On Double click, make preview editable.

Purpose

What is the purpose of this task?

  • Keyboard flow in general is getting improved.

Additional Context

Any additional information that needs to be added

@dineshsingh1 dineshsingh1 requested a review from rpPanda November 3, 2022 20:55
@rpPanda rpPanda merged commit 5e58096 into main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants