Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Fix Highlight Flow #244

Merged
merged 7 commits into from
Nov 3, 2022

Conversation

sahil-shubham
Copy link
Member

@sahil-shubham sahil-shubham commented Nov 2, 2022

In this PR

  • Page highlights don't get re-highlighted multiple times if already highlighted
  • On highlighting something new, other highlights remain highlighted

Will add in another PR because not complete yet

  • Reduced delay between saving and highlighting
  • IMPORTANT: Fix content appending and disappearance issue

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022

🦋 Changeset detected

Latest commit: a3af859

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mexit Patch
mexit-webapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linear
Copy link

linear bot commented Nov 2, 2022

WD-1671 [TASK] Fix highlight flow

Description

Multiple issues with highlights work, fix them.

  • On creating a new highlight everything is re-highlighted on the page
  • Delay in highlighting after sputlit closes (this is the animation)

Purpose

Fix things make them better and smoother.

Additional Context

Any additional information that needs to be added

@sahil-shubham sahil-shubham force-pushed the sahil-shubham-wd-1671-task-fix-highlight-flow branch from 66388e1 to 09d53f0 Compare November 2, 2022 17:49
@mukul-mehta mukul-mehta merged commit e2f5a88 into main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants