Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link shortening in extension #235

Merged

Conversation

sahil-shubham
Copy link
Member

@sahil-shubham sahil-shubham commented Oct 28, 2022

In this PR

  • Fixed link shortening for new links in the extension sidebar
  • Fixed styling for long urls
  • Fixed styling for multiple tags
  • Save link without alias when highlighting if not already shortened

Screenshot

image

@linear
Copy link

linear bot commented Oct 28, 2022

WD-1667 [BUG] Fix extension sidebar shortener

Describe the bug

Extension sidebar unable to shorten links with no existing alias, fix that. A good behaviour can also be auto saving links (without an alias) for links containing one or more highlights. This way the user can view his/her highlights right in the links view.

Additional Context

Any additional things that might help gain context of the bug

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022

🦋 Changeset detected

Latest commit: ef1ff17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mexit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sahil-shubham sahil-shubham requested a review from rpPanda October 28, 2022 20:03
@rpPanda rpPanda merged commit 1e77592 into main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants