-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mexit Command Bar #208
Mexit Command Bar #208
Conversation
🦋 Changeset detectedLatest commit: 445aad1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WD-1652 [TASK] MexIt Command Bar
DescriptionA brief description of the task
PurposeWhat is the purpose of this task?
Additional ContextAny additional information that needs to be added |
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
The highlighted element is not in view when moving selection down in the spotlight, the element is ~2 elements below and out of the cropped view of the spotlight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I cannot use "Search in mex" as it shows as empty while searching for an existing note title.
- Cannot return to regular state by
Esc
when in search in mex state. - Extension and Downloads actions are not working.
- Also mentioned in comments^ The highlighted elements when moving down the list is not visible and is ~2 items below the last item.
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
Changes
Sputlit
show results based on:- If there's no
selection
show list ofactions
available to the user.- On
search
, showtwo
sections, one havingfuzzy
search results and other section where user can directly execute the search with the presentquery
.- Added
Search In Mex
section. With this action user can search anything inMex
likeNotes
,Snippets
,Links
etc.-
On Enter
opens the active item inBacklinks
.- For
Links
, by pressingCMD+Enter
one canCopy the Shorten Link
on the clipboard.[[
and/
command based search from Search bar.useSputlitStore
zustand store for managing states ofselection
,activeItem
,highlightedTooltipState
, etc.- Use this for getting active state of
variable
withing a function orhooks
.highlight
.min-height
from Container, now it's based on items content.OnSave
, saving content in a differentNoteID
instead of selected one. [FIXED]State
always one step behind from current state. [FIXED]Input
box in caseactiveItem
is present/set.Portals
call removed fromEditor
route. Was calling every time oneditor
route change.Esc
oroutside
click,unhighlight
current selection if it's not saved.Deletion
fromhighlight
tooltip is fixed.OnSave
andOnCreate
Note fixed.Highlight
tooltip now usedFloatingUI
component instead ofTippy.js
.Screenshots