Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mexit Command Bar #208

Merged
merged 32 commits into from
Oct 19, 2022
Merged

Mexit Command Bar #208

merged 32 commits into from
Oct 19, 2022

Conversation

dineshsingh1
Copy link
Member

Changes

  • In Sputlit show results based on:
    - If there's no selection show list of actions available to the user.
    - On search, show two sections, one having fuzzy search results and other section where user can directly execute the search with the present query.
    - Added Search In Mex section. With this action user can search anything in Mex like Notes, Snippets, Links etc.
    - On Enter opens the active item in Backlinks.
    - For Links, by pressing CMD+Enter one can Copy the Shorten Link on the clipboard.
  • Removed [[ and / command based search from Search bar.
  • Created useSputlitStore zustand store for managing states of selection, activeItem, highlightedTooltipState, etc.
    - Use this for getting active state of variable withing a function or hooks.
  • Added transparency to selection highlight.
  • Create a custom editor to get deserialized content of selection from page.
  • Removed min-height from Container, now it's based on items content.
  • OnSave, saving content in a different NoteID instead of selected one. [FIXED]
  • State always one step behind from current state. [FIXED]
  • Disable Input box in case activeItem is present/set.
  • Get Portals call removed from Editor route. Was calling every time on editor route change.
  • On Esc or outside click, unhighlight current selection if it's not saved.
  • After capturing content from a scrolled content, Sputlit was going at the top of the page is fixed.
  • Deletion from highlight tooltip is fixed.
  • OnSave and OnCreate Note fixed.
  • Highlight tooltip now used FloatingUI component instead of Tippy.js.

Screenshots

Screenshot 2022-10-19 at 3 23 47 AM
Screenshot 2022-10-19 at 3 24 39 AM

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2022

🦋 Changeset detected

Latest commit: 445aad1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
mexit Minor
mexit-webapp Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linear
Copy link

linear bot commented Oct 18, 2022

WD-1652 [TASK] MexIt Command Bar

Description

A brief description of the task

  • Use CMD+SHIFT+X to open Command bar (Sputlit) in MexIt extension.
  • Default Home route, would show all the actions present currently without backlinks.
  • On selection show user recent Notes, on query show results from index worker. When there's no selection default actions would be shown.
  • Search query, would show results in two sections one with fuzzy match and other where user can directly fire the search. (Like raycast).
  • Add action called Search In Mex . Trigger this action to search anything inside Mex. Notes, Snippets and Links are searchable now. Result Items of this action can be opened directly by pressing Enter or you can copy the URL (for Links) by pressing CMD + Enter.
  • External actions Like search and open actions aren't working. On enter, doesn't execute.

Purpose

What is the purpose of this task?

  • Use Sputlit as a command center.

Additional Context

Any additional information that needs to be added

@xypnox
Copy link
Contributor

xypnox commented Oct 19, 2022

The highlighted element is not in view when moving selection down in the spotlight, the element is ~2 elements below and out of the cropped view of the spotlight.

Copy link
Contributor

@xypnox xypnox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I cannot use "Search in mex" as it shows as empty while searching for an existing note title.
  • Cannot return to regular state by Esc when in search in mex state.
  • Extension and Downloads actions are not working.
  • Also mentioned in comments^ The highlighted elements when moving down the list is not visible and is ~2 items below the last item.

@dineshsingh1 dineshsingh1 merged commit 5cfbe52 into main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants