Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Upload to CDN Via Dwindle S3 Client #440

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Conversation

mukul-mehta
Copy link
Contributor

Description

The lambda used to upload image to S3 and return the CDN URL does not exist anymore. Dwindle now supports uploading images to S3, with the use of identity pools. Change the imageUpload.ts file to upload via this new method. Since we need to perform this in a non-reactive manner, we create a client similar to the axios client exported by @workduck-io/dwindle.

Motivation and Context

Because it was broken I guess?

How has this been tested?

Built new version of dwindle, linked and tested.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Dependent PRs

Checklist:

  • My code follows the code style of this project.

@github-actions
Copy link

yarn.lock changes

Summary

Status Count
ADDED 95
UPDATED 2
Click to toggle table visibility
Name Status Previous Current
@aws-crypto/crc32 ADDED - 2.0.0
@aws-crypto/crc32c ADDED - 2.0.0
@aws-crypto/ie11-detection ADDED - 2.0.2
@aws-crypto/sha1-browser ADDED - 2.0.0
@aws-crypto/sha256-browser ADDED - 2.0.0
@aws-crypto/sha256-js ADDED - 2.0.2
@aws-crypto/supports-web-crypto ADDED - 2.0.2
@aws-crypto/util ADDED - 2.0.2
@aws-sdk/abort-controller ADDED - 3.198.0
@aws-sdk/chunked-blob-reader-native ADDED - 3.188.0
@aws-sdk/chunked-blob-reader ADDED - 3.188.0
@aws-sdk/client-cognito-identity ADDED - 3.199.0
@aws-sdk/client-s3 ADDED - 3.199.0
@aws-sdk/client-sso ADDED - 3.199.0
@aws-sdk/client-sts ADDED - 3.199.0
@aws-sdk/config-resolver ADDED - 3.198.0
@aws-sdk/credential-provider-cognito-identity ADDED - 3.199.0
@aws-sdk/credential-provider-env ADDED - 3.198.0
@aws-sdk/credential-provider-imds ADDED - 3.198.0
@aws-sdk/credential-provider-ini ADDED - 3.199.0
@aws-sdk/credential-provider-node ADDED - 3.199.0
@aws-sdk/credential-provider-process ADDED - 3.198.0
@aws-sdk/credential-provider-sso ADDED - 3.199.0
@aws-sdk/credential-provider-web-identity ADDED - 3.198.0
@aws-sdk/eventstream-codec ADDED - 3.199.0
@aws-sdk/eventstream-serde-browser ADDED - 3.199.0
@aws-sdk/eventstream-serde-config-resolver ADDED - 3.198.0
@aws-sdk/eventstream-serde-node ADDED - 3.199.0
@aws-sdk/eventstream-serde-universal ADDED - 3.199.0
@aws-sdk/fetch-http-handler ADDED - 3.199.0
@aws-sdk/hash-blob-browser ADDED - 3.198.0
@aws-sdk/hash-node ADDED - 3.198.0
@aws-sdk/hash-stream-node ADDED - 3.198.0
@aws-sdk/invalid-dependency ADDED - 3.198.0
@aws-sdk/is-array-buffer ADDED - 3.188.0
@aws-sdk/md5-js ADDED - 3.199.0
@aws-sdk/middleware-bucket-endpoint ADDED - 3.198.0
@aws-sdk/middleware-content-length ADDED - 3.199.0
@aws-sdk/middleware-endpoint ADDED - 3.198.0
@aws-sdk/middleware-expect-continue ADDED - 3.198.0
@aws-sdk/middleware-flexible-checksums ADDED - 3.198.0
@aws-sdk/middleware-host-header ADDED - 3.198.0
@aws-sdk/middleware-location-constraint ADDED - 3.198.0
@aws-sdk/middleware-logger ADDED - 3.198.0
@aws-sdk/middleware-recursion-detection ADDED - 3.198.0
@aws-sdk/middleware-retry ADDED - 3.198.0
@aws-sdk/middleware-sdk-s3 ADDED - 3.198.0
@aws-sdk/middleware-sdk-sts ADDED - 3.199.0
@aws-sdk/middleware-serde ADDED - 3.198.0
@aws-sdk/middleware-signing ADDED - 3.198.0
@aws-sdk/middleware-ssec ADDED - 3.198.0
@aws-sdk/middleware-stack ADDED - 3.198.0
@aws-sdk/middleware-user-agent ADDED - 3.198.0
@aws-sdk/node-config-provider ADDED - 3.198.0
@aws-sdk/node-http-handler ADDED - 3.199.0
@aws-sdk/property-provider ADDED - 3.198.0
@aws-sdk/protocol-http ADDED - 3.198.0
@aws-sdk/querystring-builder ADDED - 3.199.0
@aws-sdk/querystring-parser ADDED - 3.198.0
@aws-sdk/s3-request-presigner ADDED - 3.199.0
@aws-sdk/service-error-classification ADDED - 3.198.0
@aws-sdk/shared-ini-file-loader ADDED - 3.198.0
@aws-sdk/signature-v4-multi-region ADDED - 3.198.0
@aws-sdk/signature-v4 ADDED - 3.198.0
@aws-sdk/smithy-client ADDED - 3.198.0
@aws-sdk/types ADDED - 3.198.0
@aws-sdk/url-parser ADDED - 3.198.0
@aws-sdk/util-arn-parser ADDED - 3.188.0
@aws-sdk/util-base64-browser ADDED - 3.188.0
@aws-sdk/util-base64-node ADDED - 3.188.0
@aws-sdk/util-body-length-browser ADDED - 3.188.0
@aws-sdk/util-body-length-node ADDED - 3.188.0
@aws-sdk/util-buffer-from ADDED - 3.188.0
@aws-sdk/util-config-provider ADDED - 3.188.0
@aws-sdk/util-create-request ADDED - 3.198.0
@aws-sdk/util-defaults-mode-browser ADDED - 3.198.0
@aws-sdk/util-defaults-mode-node ADDED - 3.198.0
@aws-sdk/util-endpoints ADDED - 3.198.0
@aws-sdk/util-format-url ADDED - 3.199.0
@aws-sdk/util-hex-encoding ADDED - 3.188.0
@aws-sdk/util-locate-window ADDED - 3.188.0
@aws-sdk/util-middleware ADDED - 3.198.0
@aws-sdk/util-stream-browser ADDED - 3.199.0
@aws-sdk/util-stream-node ADDED - 3.199.0
@aws-sdk/util-uri-escape ADDED - 3.188.0
@aws-sdk/util-user-agent-browser ADDED - 3.198.0
@aws-sdk/util-user-agent-node ADDED - 3.198.0
@aws-sdk/util-utf8-browser ADDED - 3.188.0
@aws-sdk/util-utf8-node ADDED - 3.199.0
@aws-sdk/util-waiter ADDED - 3.198.0
@aws-sdk/xml-builder ADDED - 3.188.0
@workduck-io/dwindle UPDATED 0.0.20 0.0.21
bowser ADDED - 2.11.0
buffer UPDATED 5.7.1 6.0.3
fast-xml-parser ADDED - 4.0.11
strnum ADDED - 1.0.5
uuid ADDED - 8.3.2

@rpPanda rpPanda merged commit 6a51022 into main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants