Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Spotlight - index out of bound #438

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Conversation

xypnox
Copy link
Contributor

@xypnox xypnox commented Oct 15, 2022

Description

  • Add behavior to reset index when out of bound
    Index is reset to the last item when the index of the active elements exceeds the number of items when a change occurs in the number of items, via search query changes etc.

Motivation and Context

Earlier the index remained as what it was even if the number of items changed to a lesser quantity and the user had to manually use the up arrow key to make it focus on any of the lesser items.

How has this been tested?

Using keyboard to change index and the search query in spotlight.

Screenshots (if appropriate):

NA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.

@xypnox xypnox requested review from rpPanda and dineshsingh1 and removed request for rpPanda October 15, 2022 10:39
@dineshsingh1 dineshsingh1 merged commit 1f03411 into main Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants