Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Search Index On Refactor #436

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

dineshsingh1
Copy link
Member

Description

  • Save Title instead path for indexing Notes.
  • On Refactor, update the local search index.
  • In OnSave function, pass default namespace if namespace doesn't exist.
  • Moved getInitialNode to Renderer code (was always throwing error on hot reload).

Motivation and Context

  • Fixes

How has this been tested?

  • Tested by renaming note

Screenshots (if appropriate):

---

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.

@linear
Copy link

linear bot commented Oct 7, 2022

WD-1607 [TASK] Update Search Index on Refactor

Description

A brief description of the task

  • On Refactoring/Renaming a Note update the search index in Mex.

Purpose

What is the purpose of this task?

  • After Refactoring, user wasn't able to search the refactored Note.

Additional Context

Any additional information that needs to be added

@dineshsingh1 dineshsingh1 requested a review from rpPanda October 7, 2022 11:35
rpPanda
rpPanda previously approved these changes Oct 7, 2022
@rpPanda rpPanda merged commit df22373 into main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants