-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove number of dependencies in Main Process #431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4e9abe
to
dff743f
Compare
rpPanda
reviewed
Oct 3, 2022
xypnox
reviewed
Oct 3, 2022
4a7a59c
to
69b2e55
Compare
69b2e55
to
eec64da
Compare
rpPanda
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate a dependency graph of the main process and reduce the number of modules imported. It can be done by the following:
import type
syntax.Motivation and Context
Main process was depending on files it should not, this was causing an issue where it would re-render the entire app on making a change in what was supposed to be renderer but caused a change in main.
Screenshots (if appropriate):
We create a dependency graph starting with the file
electron/main.ts
.On current
main
, the size:Post this change:
Types of changes
Dependent PRs
Checklist: