Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHSidebar redesign #429

Merged
merged 17 commits into from
Oct 1, 2022
Merged

RHSidebar redesign #429

merged 17 commits into from
Oct 1, 2022

Conversation

xypnox
Copy link
Contributor

@xypnox xypnox commented Sep 30, 2022

Description

In Reminders

  • No need to show the note title
  • No need to show time information twice
  • Show buttons on hover

Suggestions

  • Combine the suggestions with related notes
  • Show only notes
  • Scroll to block if blockid present in preview

Backlinks

  • Click on icon/title to toggle forward links’

Snippets

  • In RHS replaces suggestions
  • Search and use
  • Card with preview, last used, Tags
  • Preview on hover
  • Insert on Click

Fixes

  • Fix f/F in task view modal opening filter menu at the back
  • Fix autoclose of rhsidebar when navigating in editor only

  • Add snippets instead of suggestions
  • Add snippet card with interaction
  • Use accordion auto close/open when overflow in sidebar

Motivation and Context

New RHS design

How has this been tested?

  • Using sidebar
  • Using suggestion embed/link
  • Using forward backward links
  • Using snippets

Screenshots (if appropriate):

Screenshot 2022-10-01 at 8 26 04 PM

Screenshot 2022-10-01 at 8 19 55 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.

@linear
Copy link

linear bot commented Sep 30, 2022

WD-1585 [TASK] RHSidebar Redesign

Description

A brief description of the task

  • Combine the suggestions with related notes
  • De-emphasize Outline
  • Backlinks and forward links
  • Preview
    • Scroll to block if blockid present in preview of suggested notes
  • Fix autoclose rhsidebar on opening note in editor page

Purpose

What is the purpose of this task?

  • Simplify rhsidebar

Additional Context

Any additional information that needs to be added

https://www.figma.com/file/1DtVsN8K9WNYGcYptiB4eR/Wireframes?node-id=179%3A7520

@xypnox xypnox marked this pull request as ready for review October 1, 2022 14:56
@xypnox xypnox requested review from dineshsingh1 and rpPanda October 1, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants