Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll to active element in dropdown #421

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Scroll to active element in dropdown #421

merged 1 commit into from
Sep 27, 2022

Conversation

xypnox
Copy link
Contributor

@xypnox xypnox commented Sep 27, 2022

Description

  • Fix scroll to element in dropdown items

Motivation and Context

Needed scroll

How has this been tested?

  • Using keyboard to change active items

Screenshots (if appropriate):

NA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.

@linear
Copy link

linear bot commented Sep 27, 2022

WD-1579 Filter shortcuts

Change behaviour of filter shortcuts:

  • Shift f to remove filter
  • F to add filter
  • Esc to close filter rather than remove all
  • Don't navigate on Esc
  • Save change on changing global join

@rpPanda rpPanda merged commit be4b38d into main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpPanda rpPanda rpPanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xypnox @rpPanda