Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Filter shortcuts, sidebar animate, block highlight #419

Merged
merged 8 commits into from
Sep 26, 2022

Conversation

xypnox
Copy link
Contributor

@xypnox xypnox commented Sep 26, 2022

Description

  • Shift f to remove filter

  • F to add filter

  • Save change on changing global join

  • Esc to close filter rather than remove all

  • Don't navigate on Esc

  • Animations should skip on keyboard shortcut for sidebar space switching

  • Searched note with block highligted, the highlight is not removed

Motivation and Context

Fixes

How has this been tested?

Using the respective flows

Screenshots (if appropriate):

NAVC

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.

@linear
Copy link

linear bot commented Sep 26, 2022

WD-1579 Filter shortcuts

Change behaviour of filter shortcuts:

  • Shift f to remove filter
  • F to add filter
  • Esc to close filter rather than remove all
  • Don't navigate on Esc
  • Save change on changing global join

@rpPanda rpPanda merged commit 0a2664f into main Sep 26, 2022
@rpPanda rpPanda deleted the xypnox-wd-1579-filter-shortcuts branch September 26, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants