Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge gutenberg development branch into master #759

Merged
merged 14 commits into from
Mar 21, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Mar 19, 2019

This PR updates gutenberg to merge rnmobile/develop into master.
Gutenberg PR: WordPress/gutenberg#14503

It also updates the eslint plugins and similar and makes the appropriate code update to fix the eslint errors we were having with the new changes.

Testing Instructions

  • Run the app on ios and android and make sure there is no regression

@Tug Tug self-assigned this Mar 19, 2019
@Tug Tug requested review from SergioEstevao and hypest March 19, 2019 08:23
@SergioEstevao
Copy link
Contributor

The app is compiling and working correctly but the unit tests yarn jest are failing.

@Tug
Copy link
Contributor Author

Tug commented Mar 19, 2019

@SergioEstevao Yep I'm waiting for the tests to complete here with travis because they're passing on my side 🤔
Edit: Seems to be all green now

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine for me now.

@Tug Tug merged commit f03630a into develop Mar 21, 2019
@Tug Tug deleted the update/gutenberg-ref-master branch March 21, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants