-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use last gutenberg changes including the editor and block-editor packages refactoring #731
Conversation
… new editor package organization
…ditor-refactoring
Hey @Tug - this is working super good! 🎉 I did find something that I wanted to share early: It looks like there is a new formatting option on paragraph and heading blocks. |
@etoledom Thanks for reviewing. About the new button that's interesting! I didn't notice it :) Looking at it now 👍 |
So it seems the |
Thanks for the update @Tug ! Testing on device it gives me the same error that is shown on the CI tests: |
@etoledom Yep, I needed to make an update on gutenberg after the merge, our babel config doesn't support |
Thank you @Tug for the update! It looks super good on iOS. Just wanted to point out that the last commit on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on iOS example app and WPiOS: ✅ 🎉
I didn't spot any regression or weird behavior.
Tested on Android example app and WPAndroid:
I saw a crash in both example and WP app, not sure if it's related to this or is something else.
The error happened trying to split a paragraph block. It doesn't always happen and I'm not sure about exact steps to reproduce it.
It would be nice if @daniloercoli, @mzorz or @marecar3 could take a look and see if it's related to this PR.
I give my ✅ for iOS.
Let's wait for the Android side to be verified 👍
Great work as always @Tug ! 🎉
Tested on Android and was not able to reproduce the problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good on the iOS side!
If @daniloercoli is happy with Android, let's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nice work @Tug 🎉 |
Requires WordPress/gutenberg#14375
WordPress/gutenberg#13088 introduced a breaking change for us, we need to update our dependency to the editor store and components as it (the editor package) has been split in 2 packages:
core/editor
andcore/block-editor
for more flexibility.This PR updates our code to make it work with those changes:
The main change of this PR is the switch from
core/editor
tocore/block-editor
selectors and actions inBlockManager
along with the use ofBlockEditorProvider
in the parent component which makes sure both stores are in sync.In
AppContainer
,MainApp
's is removed and its logic is moved toAppContainer
as the component we're usingBlockEditorProvider
handles defining theSlotFillProvider
already.editorSetup()
is simplified insrc/index.js
and most of its logic is moved toedit-post/src/index.native.js
. To achieve this we needed to also moveUnsupportedBlock
to gutenberg.Styles (open for discussion):
src/colors.scss
andsrc/variables.(ios|android).scss
are replaced withsrc/_colors.scss
andsrc/_variables.(ios|android).scss
and now supersede the files ingutenberg/assets/stylesheets/
. This means that, just like with gutenberg, we don't need to explicitly have@import "variables.scss";
or@import "colors.scss";
in our stylesheets. This is closer to what we have on gutenberg web. However it also means that we need to redefine all necessary variables when we decide to have our own version ofsrc/_{file}.scss
.@wordpress/block-editor
,@wordpress/edit-post
and@wordpress/token-list
are added to the list of symlinked packagesTesting Instructions