-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image cropped vertically #447
Conversation
Awesome! Thanks for fixing this @etoledom!! |
Hey @iamthomasbishop - glad you like it :) I'm wandering what do you think about an activity indicator when the image is loading? (That is pretty much the behavior on web, but on mobile I would expect some kind of activity indicator) |
I would also expect a loading indicator. Is there any chance we can utilize the same approach that we took on Aztec uploads, where you see a loader over the top of the media as it loads? |
I created a new issue for the activity indicator task. |
Hey @Tug ! |
The |
Fixes #444
Gutenberg side: WordPress/gutenberg#13096
The image size implementations tries to follow closely the web implementation. I tried to share some code from
ImageSize
but most of it is platform specific. I made a smallutils
to share some math calculations.On a future PR I plan to implement some kind of loading indicator.
cc @iamthomasbishop
To test: