Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undo/redo functionality in links when applying text format [Android] #4290

Merged
merged 3 commits into from
Nov 25, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Nov 25, 2021

Fixes #3136

This fix was made in Aztec-Android (reference), so the Gutenberg reference points to a commit where the version of Aztec-Android has been bumped to the newer version v1.5.1.

To test:

  1. Run the command npm run core android to build the demo app.
  2. Add a a rich-text based component with content (Paragraph, Heading, Quote, Media Caption, etc...).
  3. Write a word and select it.
  4. Press the link format button.
  5. Fill the options and dismiss to add a link.
  6. Select the word.
  7. Press the bold, italic or strikethrough button to apply text format.
  8. Press the Undo button multiple times until all changes are reverted.
  9. Observe that the undo functionality works as expected and that doesn't get blocked as described in Undo/redo - Apply text format to a link breaks the undo functionality Undo/redo - Apply text format to a link breaks the undo functionality #3136.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the [Type] Bug Something isn't working label Nov 25, 2021
@fluiddot fluiddot self-assigned this Nov 25, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 25, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Verified it works OK via the WPAndroid installable build. Verified that both the Classic editor and gb-mobile work fine.

@fluiddot fluiddot added this to the 1.68.0 (18.9) milestone Nov 25, 2021
@fluiddot fluiddot enabled auto-merge November 25, 2021 16:20
@fluiddot fluiddot merged commit 595ffbc into develop Nov 25, 2021
@fluiddot fluiddot deleted the fix/undo-redo-link-styles branch November 25, 2021 16:41
@fluiddot fluiddot mentioned this pull request Nov 26, 2021
2 tasks
@guarani guarani mentioned this pull request Dec 9, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] Android [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undo/redo - Apply text format to a link breaks the undo functionality
3 participants