Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible Android activity indicator #3716

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jul 9, 2021

Fixes #3708. Apply a patch for the React Native ActivityIndicator rendering invisible on Android. This applies the same patch that was previously applied to the Embed block to to React Native itself.

The core issue in React Native appears to be wider reaching, but I chose to limit the scope of the patch to the one issue we are currently facing (i.e. invisible activity indicators), as I was concerned applying a deeper, untested change might introduce regressions elsewhere.

This patch can be removed once we upgrade to a React Native version including fixes for the related issues:

To test: See WordPress/gutenberg#33337.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun added the [Type] Regression Existing functionality that got broken label Jul 9, 2021
@dcalhoun dcalhoun self-assigned this Jul 9, 2021
@dcalhoun dcalhoun marked this pull request as ready for review July 9, 2021 21:11
@dcalhoun dcalhoun requested a review from ceyhun July 9, 2021 21:11
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 12, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun enabled auto-merge July 12, 2021 21:40
@dcalhoun dcalhoun merged commit 13784ab into develop Jul 12, 2021
@dcalhoun dcalhoun deleted the fix/invisible-android-activity-indicator branch July 12, 2021 21:59
@fluiddot fluiddot mentioned this pull request Jul 22, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Regression Existing functionality that got broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] RN ActivityIndicator component is blank and does not show up unless explicit color prop is provided
2 participants