Fix undo/redo not working on small changes on RichText #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzorz
approved these changes
Nov 29, 2018
There was a problem hiding this comment.
Tested, explanation and code make sense, and was able to confirm it fixes the behavior it intends to fix.
There are a few cases I found that don't work exactly as expected but this PR is correct in that it fixes the described behavior.
LGTM 
remember to update Gutenberg's hash once the other PR gets merged before merging this one 👍
…g-mobile into fix/undo-redo-not-working-with-small-changes * 'master' of https://github.com/wordpress-mobile/gutenberg-mobile: Create blocks empty by default Update references Set keyboardShouldPersistTaps to always Updated RNAztec reference
daniloercoli
deleted the
fix/undo-redo-not-working-with-small-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where the undo/redo feature was not working if small changes were made to the content. Tapping
undodoes not update the text in the RichText powered block.Actually the undo/redo feature was not working fine even if there were lot of changes to the RichText content, but in this case the problem was less noticeable, since the undo/redo feature replaced the content with the wrong text.
GB side PR: WordPress/gutenberg#12417
To test this PR:
Start the demo app
Make a small change to a Para or Heading block
Tap undo
It should revert the content
Start writing and deleting into RichText powered block, and have fun with the undo/redo feature. It should work.
Please test also writing fast on Android.