Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ui strings using filters #2678

Merged
merged 6 commits into from
Oct 5, 2020
Merged

Refactor ui strings using filters #2678

merged 6 commits into from
Oct 5, 2020

Conversation

etoledom
Copy link
Contributor

gutenberg PR: WordPress/gutenberg#25697

Implements changes from WordPress/gutenberg#25697, following the recommendations from #2610 (review) to refactor the HOC as a filter.

UBE_toggle

To test:

  • Run this PR on gutenberg-mobile iOS npm run start:reset npm run start core ios.
  • Scroll to the bottom and press on the unsupported block UI.
  • Check that the alert UI looks like in the screenshots.
  • Toggle the Missing block UI Alert as shown on the screenshots and check the UI again.
  • Do this three times and verify with the screenshots.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added this to the 1.39 milestone Sep 29, 2020
@etoledom etoledom requested a review from Tug September 29, 2020 11:03
@etoledom etoledom self-assigned this Sep 29, 2020
@etoledom etoledom mentioned this pull request Sep 29, 2020
Merged
6 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 29, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Tug
Tug approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@etoledom etoledom merged commit 87ebf37 into develop Oct 5, 2020
@etoledom etoledom deleted the issue/refactor-ui-strings branch October 5, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug approved these changes

Assignees

@etoledom etoledom

Labels
None yet
Projects
None yet
Milestone
1.39
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @Tug