[RNMobile] Add support Reusable blocks #2627
Conversation
Update develop branch from original repo
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Update develop branch from original repo
fluiddot
force-pushed
the
rnmobile/2575-support-reusable-blocks
branch
from
358be48 to
001737e
Compare
Update master branch from original repo.
fluiddot
force-pushed
the
rnmobile/2575-support-reusable-blocks
branch
from
001737e to
30d95f6
Compare
Update master branch from original repo
fluiddot
force-pushed
the
rnmobile/2575-support-reusable-blocks
branch
from
2a3dba0 to
c4bda9d
Compare
Update master branch from original repo
fluiddot
force-pushed
the
rnmobile/2575-support-reusable-blocks
branch
3 times, most recently
from
f593103 to
44fe0e4
Compare
Update master branch from original repo
fluiddot
force-pushed
the
rnmobile/2575-support-reusable-blocks
branch
from
44fe0e4 to
49e74cd
Compare
Update master branch from original repo
Update gutenberg ref Update gutenberg ref
fluiddot
force-pushed
the
rnmobile/2575-support-reusable-blocks
branch
from
e2e58dd to
c38df68
Compare
There was a problem hiding this comment.
Sorry for the delay getting to this, it slipped through.
Just a heads-up, this PR doesn't seem to be pointing to the latest commit on the related Gutenberg PR.
The tests fail only because this is a fork. I can push these commits to another branch, make a temporary PR and when CI passes, this PR will also automatically turn green.
| @@ -14,6 +14,7 @@ Unreleased | |||
| * [***] Full-width and wide alignment support for Columns | |||
| * [***] New Block: File [https://github.com/wordpress-mobile/gutenberg-mobile/pull/2835] | |||
| * [**] Image block - Add link picker to the block settings and enhance link settings with auto-hide options [https://github.com/WordPress/gutenberg/pull/27292] | |||
| * [**] Add Support to Insert Existing Reusable Blocks from the Editor. | |||
There was a problem hiding this comment.
This can go in the Unreleased section above.
There was a problem hiding this comment.
I saw in a P2 post that the changes should be added in the CHANGELOG file in Gutenberg repository instead of here, right?
If that’s the case I’ll add this change in the Gutenberg PR so in the new PR for Gutenberg-mobile only the submodule reference update will be included.
There was a problem hiding this comment.
True, I'd overlooked that, thanks for noticing!
Thanks for reviewing it @guarani! I created a new PR directly in the |
|
I’m closing this PR because there’s a new one created directly in the |
Gutenberg PR-> WordPress/gutenberg#25265Second part (adding Reusable blocks to the inserter menu):
Gutenberg PR-> WordPress/gutenberg#25383Gutenberg-mobile PR-> #2644Related to #2575
This PR is the first part of the issue Add Support to Insert Existing Reusable Blocks from the Editor.
The scope of this issue is limited to add Reusable blocks to the inserter menu, however due to the need of registering the Reusable block type (core/block), I also had to add support for presenting it in the editor.
The edition support will be added in this issue, so for now this PR only provides the preview mode of this type of block.
To test:
Check test steps in Gutenberg PR WordPress/gutenberg#25265
PR submission checklist: