Cover block - Allow media editing #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
geriux
force-pushed
the
feature/cover-media-editing
branch
from
07e171d to
902cf1f
Compare
This was referenced Jul 7, 2020
geriux
force-pushed
the
feature/cover-media-editing
branch
from
902cf1f to
472a11a
Compare
geriux
changed the title
geriux
force-pushed
the
feature/cover-media-editing
branch
from
472a11a to
6539050
Compare
added 2 commits
July 15, 2020 13:02
geriux
force-pushed
the
feature/cover-media-editing
branch
from
6539050 to
0a18c5f
Compare
geriux
force-pushed
the
feature/cover-media-editing
branch
from
0a18c5f to
a190fb0
Compare
added 2 commits
July 20, 2020 14:19
# Conflicts: # gutenberg
geriux
force-pushed
the
feature/cover-media-editing
branch
from
a190fb0 to
a318d84
Compare
geriux
changed the title
geriux
force-pushed
the
feature/cover-media-editing
branch
from
a318d84 to
05d6917
Compare
geriux
force-pushed
the
feature/cover-media-editing
branch
from
05d6917 to
9d87b97
Compare
geriux
force-pushed
the
feature/cover-media-editing
branch
from
9d87b97 to
5379d4c
Compare
mkevins
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Approved via: WordPress/gutenberg#23280 (review) - just have to update the submodule reference. LGTM!
geriux
force-pushed
the
feature/cover-media-editing
branch
from
482a18a to
225f509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2388
Gutenberg PR-> WordPress/gutenberg#23280WordPress-iOS PR-> wordpress-mobile/WordPress-iOS#14420WordPress-Android PR-> wordpress-mobile/WordPress-Android#12356This PR adds Media editing functionality to the Cover block. With the recent changes and refactor we can reuse the same functionality as in Image and Media & Text block.
To test check the
GutenbergPR description.PR submission checklist:
RELEASE-NOTES.txtif necessary.