-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/1592 fix alignment hiding image placeholder #1631
Merged
mchowning
merged 2 commits into
develop
from
issue/1592_fix_alignment_hiding_image_placeholder
Dec 17, 2019
Merged
Issue/1592 fix alignment hiding image placeholder #1631
mchowning
merged 2 commits into
develop
from
issue/1592_fix_alignment_hiding_image_placeholder
Dec 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
etoledom
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via WordPress/gutenberg#18793 (review) 🎉
etoledom
reviewed
Dec 17, 2019
@@ -1,3 +1,7 @@ | |||
1.19.0 | |||
------ | |||
* Fix bug where image placeholders would sometimes not be shown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably go to 1.20.0.
a643eba
to
cca4d08
Compare
6 tasks
cca4d08
to
7df54fd
Compare
2 tasks
This was referenced Jan 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1592
This fixes a bug that was introduced with the addition of paragraph alignment options. In particular, the placeholder icon would not display for an aligned image block if the image could not be downloaded.
Related gutenberg PR
To test:
Update release notes:
RELEASE-NOTES.txt
.