Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gravatar to 3.2.0 #24000

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Bump Gravatar to 3.2.0 #24000

wants to merge 2 commits into from

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Jan 22, 2025

Fixes #

Bringing some new features and bug fixes to the Gravatar's Avatar Quick Editor.

  • New avatar settings:
    • Alt text
    • Rating
  • "No selected avatar" warning

To test:

Smoke testing for the added features.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@pinarol pinarol added the Gravatar Gravatar SDK related updates label Jan 22, 2025
@pinarol pinarol added this to the 25.8 milestone Jan 22, 2025
@pinarol pinarol self-assigned this Jan 22, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 22, 2025

1 Warning
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 22, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24000-81c61f4
Version25.7.1
Bundle IDcom.jetpack.alpha
Commit81c61f4
App Center Buildjetpack-installable-builds #10494
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 22, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24000-81c61f4
Version25.7.1
Bundle IDorg.wordpress.alpha
Commit81c61f4
App Center BuildWPiOS - One-Offs #11462
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@pinarol pinarol force-pushed the wppinar/bump-gravatar-to-3.2.0 branch from d913615 to 81c61f4 Compare February 7, 2025 09:40
@pinarol pinarol marked this pull request as ready for review February 7, 2025 09:42
@pinarol
Copy link
Contributor Author

pinarol commented Feb 7, 2025

Ready to review @etoledom @andrewdmontgomery

@pinarol
Copy link
Contributor Author

pinarol commented Feb 7, 2025

This warning is outdated and faulty, we can ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gravatar Gravatar SDK related updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants