Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the weak_delegate SwiftLint rule #21068

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Enable the weak_delegate SwiftLint rule #21068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec63d5b
Enable the weak_delegate SwiftLint rule
crazytonyli Jul 11, 2023
e662c7c
Ignore a few weak_delegate SwiftLint rule violations
crazytonyli Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .swiftlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ remote_timeout: 10.0

opt_in_rules:
- overridden_super_call
- weak_delegate

overridden_super_call:
severity: error

weak_delegate:
severity: error
1 change: 1 addition & 0 deletions WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ class GutenbergViewController: UIViewController, PostEditor, FeaturedImageDelega

let navigationBarManager: PostEditorNavigationBarManager

// swiftlint:disable:next weak_delegate
lazy var attachmentDelegate = AztecAttachmentDelegate(post: post)

lazy var mediaPickerHelper: GutenbergMediaPickerHelper = {
Expand Down
1 change: 1 addition & 0 deletions WordPress/Classes/ViewRelated/Media/MediaItemViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class MediaItemViewController: UITableViewController {

}

// swiftlint:disable:next weak_delegate
let delegate = DownloadDelegate()

@objc let media: Media
Expand Down
2 changes: 2 additions & 0 deletions WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ class ReaderDetailViewController: UIViewController, ReaderDetailView {

/// The table view that displays Comments
@IBOutlet weak var commentsTableView: IntrinsicTableView!

// swiftlint:disable:next weak_delegate
private let commentsTableViewDelegate = ReaderDetailCommentsTableViewDelegate()

/// The table view that displays Related Posts
Expand Down
1 change: 1 addition & 0 deletions WordPress/Classes/ViewRelated/Themes/ThemeBrowserViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public protocol ThemePresenter: AnyObject {

@IBOutlet weak var collectionView: UICollectionView!

// swiftlint:disable:next weak_delegate
fileprivate lazy var customizerNavigationDelegate: ThemeWebNavigationDelegate = {
return ThemeWebNavigationDelegate()
}()
Expand Down
1 change: 1 addition & 0 deletions WordPress/WordPressTest/Dashboard/BlazeCampaignsStreamTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import WordPressKit
final class BlazeCampaignsStreamTests: CoreDataTestCase {
private var sut: BlazeCampaignsStream!
private var blog: Blog!
// swiftlint:disable:next weak_delegate
private var delegate = MockCampaignsStreamDelegate()
private let service = MockBlazePaginatedService()

Expand Down
1 change: 1 addition & 0 deletions WordPress/WordPressTest/Mention/SuggestionTableViewTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import XCTest
final class SuggestionTableViewTests: CoreDataTestCase {

private var view: SuggestionsTableView!
// swiftlint:disable:next weak_delegate
private var delegate: SuggestionsTableViewDelegateMock!
private var viewModel: SuggestionsListViewModelType {
return view.viewModel
Expand Down
1 change: 1 addition & 0 deletions WordPress/WordPressTest/ReferrerDetailsViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import XCTest

class ReferrerDetailsViewModelTests: XCTestCase {
private var sut: ReferrerDetailsViewModel!
// swiftlint:disable:next weak_delegate
private var spyDelegate: ViewModelDelegateSpy!

override func setUpWithError() throws {
Expand Down