Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract build phase to copy Gutenberg resources in script #20719

Merged
merged 1 commit into from
May 22, 2023

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented May 22, 2023

I run into this script while working on #20717, when it failed because the Pods/Gutenberg/bundle/ios folder was no longer there.

I am not sure how much of this script will be necessary with the XCFramework setup, but I have a feeling at least some of it will. In such case, we can benefit from centralizing it so that we can more easily modify it when the time comes.

For what is worth, any build phase run script can benefit from being extracted in a dedicated file. The Xcode run script text view is not a good medium where to write code. 😅

Testing

I run the app in the Simulator and verified the block editor loaded and that images were there. Can you think of anything else?

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

@mokagio mokagio force-pushed the mokagio/extract-copy-gutenberg-js branch from 861ee1a to e345b84 Compare May 22, 2023 06:41
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label May 22, 2023
@mokagio mokagio added this to the 22.5 milestone May 22, 2023
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20719-e345b84
Version22.4
Bundle IDorg.wordpress.alpha
Commite345b84
App Center BuildWPiOS - One-Offs #5743
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20719-e345b84
Version22.4
Bundle IDcom.jetpack.alpha
Commite345b84
App Center Buildjetpack-installable-builds #4773
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio enabled auto-merge May 22, 2023 10:19
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relocating this makes sense to me. 🚀

I verified the block editor loaded, including local images found within the editor:

  1. Tap the three-dot menu in the top-right corner.
  2. Tap Help & Support.
  3. Navigate to a help article.

@mokagio mokagio merged commit 416615c into trunk May 22, 2023
@mokagio mokagio deleted the mokagio/extract-copy-gutenberg-js branch May 22, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants