Extract build phase to copy Gutenberg resources in script #20719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run into this script while working on #20717, when it failed because the
Pods/Gutenberg/bundle/ios
folder was no longer there.I am not sure how much of this script will be necessary with the XCFramework setup, but I have a feeling at least some of it will. In such case, we can benefit from centralizing it so that we can more easily modify it when the time comes.
For what is worth, any build phase run script can benefit from being extracted in a dedicated file. The Xcode run script text view is not a good medium where to write code. 😅
Testing
I run the app in the Simulator and verified the block editor loaded and that images were there. Can you think of anything else?
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary. N.A.UI changes testing checklist: Not a UI PR.