fix: Image block preserves alt text from media library #18919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
changed the title
When the alt text for a media item is present in the media library, that value should be copied into the Image block when inserted. This behavior avoids the need to re-enter the alt text for each image inserted into the post content.
dcalhoun
force-pushed
the
fix/image-block-preserves-alt-text
branch
from
9d73ea1 to
09ca9e8
Compare
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
derekblank
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
I was able to successfully test using the native WPiOS app following these steps for Image w/ alt text, Video, and File blocks, and did not note any issues from the code. LGTM. 👍
…WordPress-iOS into fix/image-block-preserves-alt-text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#4977. When the alt text for a media item is present in the media library, copy the alt text into the Image block when the media item is selected. The changes in this PR ensure the alt text value is exposed to the block editor.
To test: See steps outlined in WordPress/gutenberg#41839.
Regression Notes
Inserting various types of media may break.
Manually tested inserting various media blocks within the editor.
None, majority of work and automated testing placed in Gutenberg.
PR submission checklist:
RELEASE-NOTES.txtif necessary.