Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gutenberg-mobile release 1.78.1 #18895

Merged
merged 6 commits into from
Jun 16, 2022
Merged

Integrate gutenberg-mobile release 1.78.1 #18895

merged 6 commits into from
Jun 16, 2022

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Jun 16, 2022 •
edited by dcalhoun
Loading

Description

This PR incorporates the 1.78.1 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#4961

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB added the Gutenberg Editing and display of Gutenberg blocks. label Jun 16, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 16, 2022 •
edited
Loading

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@SiobhyB SiobhyB mentioned this pull request Jun 16, 2022
Merged
4 tasks
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 16, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18895-80ed499 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 16, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18895-80ed499 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@SiobhyB SiobhyB requested a review from dcalhoun June 16, 2022 15:01
@SiobhyB SiobhyB marked this pull request as ready for review June 16, 2022 15:01
dcalhoun
dcalhoun reviewed Jun 16, 2022
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

WDYT about adding release notes for the changes? It may be too late to include notes with the published app release, but it may still be worthwhile.

Podfile Outdated Show resolved Hide resolved
dcalhoun added 3 commits June 16, 2022 14:15
@dcalhoun
Merge pull request #18898 from wordpress-mobile/gutenberg/update_gall…
ecc9da9 
…ery_tests

[RNMobile] Update "testAddGalleryBlock" test case to reflect expected content for v1 of Gallery block
@dcalhoun
Update Gutenberg ref
d546d8b
@dcalhoun
Fix Podfile syntax consistency
80ed499 
Use newer syntax for Gutenberg ref.
@dcalhoun dcalhoun added this to the 20.1 ❄️ milestone Jun 16, 2022
@dcalhoun dcalhoun merged commit e507423 into release/20.1 Jun 16, 2022
@dcalhoun dcalhoun deleted the gutenberg/integrate_release_1.78.1 branch June 16, 2022 23:39
@mokagio mokagio mentioned this pull request Jun 20, 2022
Merged
7 tasks
@mokagio
Copy link
Contributor

mokagio commented Jun 20, 2022

@SiobhyB this has been bundled as part of 20.1 beta 2 (20.1.0.2).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
20.1
Development

Successfully merging this pull request may close these issues.
4 participants
@SiobhyB @wpmobilebot @mokagio @dcalhoun