Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Highlight Tooltip follow button callback #18848

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

alpavanoglu
Copy link
Contributor

Refs pbArwn-4oo-p2

To test:

  1. Enable local feature flag "Feature Highlight Tooltip".
  2. Go to Reader, into any post that is not already followed.
  3. Tap on anchor or scroll to Tooltip.
  4. Tap on "Follow Conversation" button
  5. The tooltip and pulse indicator must be dismissed.
  6. Tooltip shouldn't be shown again (either on another post or once this post is unfollowed and opened again).

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 9, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18848-9ed2473 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 9, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18848-9ed2473 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@wargcm wargcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It properly dismisses when I tap on 'Follow conversation' but for this:

Tooltip shouldn't be shown again (either on another post or once this post is unfollowed and opened again).

I'm seeing it appear again after I unfollow and then view the post again.

follow-conversation-callback.mp4

Copy link
Contributor

@wargcm wargcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alpavanoglu It properly hides it now after tapping on 'Follow conversation'. LGTM! :shipit:

@alpavanoglu alpavanoglu merged commit 2c69a95 into trunk Jun 10, 2022
@alpavanoglu alpavanoglu deleted the feature/follow-conversation-button-callback branch June 10, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants