Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable large headers / white nav bar feature flag #16137

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

frosty
Copy link
Contributor

@frosty frosty commented Mar 21, 2021

Refs #15750. This PR enables the large headers / white navigation bars feature flag for all users, for 17.0.

To test

There shouldn't be much to rest here, as the feature itself has been tested during implementation through other PRS.

  • Build and run. Ensure you see white navigation bars, serif fonts in the navigation bars, and large header text for My Site, Reader, and Notifications.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@frosty frosty added this to the 17.0 milestone Mar 21, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 21, 2021

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 44306. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working OK on an iPad, but on an iPhone 11 I couldn't get the site picker modal to show up after I'd opened the editor (both when running locally and when running the App Center build). It seems like switching tabs "resets" this though and allows me to open the site picker modal again.

Approving now since it seems like others haven't ran into these issues and we need to merge this for the 17.0 release cut.

@frosty
Copy link
Contributor Author

frosty commented Mar 22, 2021

Thanks @guarani! Going to go ahead and merge for now, as @Gio2018 was also unable to replicate, but we'll keep and eye on these issues during testing!

@frosty frosty merged commit 46fe989 into develop Mar 22, 2021
@frosty frosty deleted the feature/enable-large-headers branch March 22, 2021 17:07
guarani added a commit that referenced this pull request May 11, 2021
After the site picker was made to be a modal (#16137), when a user changed to a different site, the app was not populating the value of `blog.webEditor`, which is needed by the Unsupported Block Editor (UBE).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants