-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Hide audio block on free sites #15865
Merged
jd-alexander
merged 3 commits into
gutenberg/integrate_release_1.46.1
from
feature/show-hide-audio-block
Feb 16, 2021
Merged
[Gutenberg] Hide audio block on free sites #15865
jd-alexander
merged 3 commits into
gutenberg/integrate_release_1.46.1
from
feature/show-hide-audio-block
Feb 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can trigger an installable build for these changes by visiting CircleCI here. |
2 tasks
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
30a5b83
to
4749080
Compare
jd-alexander
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes @ceyhun Tested using the following flows:
- WPCom simple site with a free plan. - Audio block is not shown in the inserter.
- WPCom simple site using a paid plan - Audio block is shown in the inserter.
- Self-hosted site - Audio block is shown in the inserter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide audio block on free sites.
gb-mobile PR: wordpress-mobile/gutenberg-mobile#3129
Testing
PR submission checklist:
RELEASE-NOTES.txt
if necessary.