Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Hide audio block on free sites #15865

Merged

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Feb 11, 2021

Hide audio block on free sites.

gb-mobile PR: wordpress-mobile/gutenberg-mobile#3129

Testing

  1. Switch to a free/simple site
  2. Open editor
  3. Tap block inserter
  4. Audio Block should not be in the list

  1. Switch to a paid/self-hosted site
  2. Open editor
  3. Tap block inserter
  4. Audio Block should be in the list

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ceyhun ceyhun added [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. labels Feb 11, 2021
@ceyhun ceyhun requested a review from jd-alexander February 11, 2021 15:55
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 11, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 11, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ceyhun ceyhun force-pushed the feature/show-hide-audio-block branch from 30a5b83 to 4749080 Compare February 15, 2021 14:36
@ceyhun ceyhun changed the base branch from release/16.7 to gutenberg/integrate_release_1.46.1 February 15, 2021 14:36
@ceyhun ceyhun added this to the 16.7 ❄️ milestone Feb 15, 2021
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes @ceyhun Tested using the following flows:

  1. WPCom simple site with a free plan. - Audio block is not shown in the inserter.
  2. WPCom simple site using a paid plan - Audio block is shown in the inserter.
  3. Self-hosted site - Audio block is shown in the inserter.

@jd-alexander jd-alexander merged commit 0a9759c into gutenberg/integrate_release_1.46.1 Feb 16, 2021
@jd-alexander jd-alexander deleted the feature/show-hide-audio-block branch February 16, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants