Change a few delegate properties in Signup to be weak references

wordpress-mobile · Jul 11, 2023 · a530793 · a530793
1 parent db15a47
commit a530793
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/WordPress/Classes/ViewRelated/NUX/SignupEpilogueCell.swift b/WordPress/Classes/ViewRelated/NUX/SignupEpilogueCell.swift
@@ -2,7 +2,7 @@ import UIKit
 import WordPressAuthenticator
 
 
-protocol SignupEpilogueCellDelegate {
+protocol SignupEpilogueCellDelegate: AnyObject {
     func updated(value: String, forType: EpilogueCellType)
     func changed(value: String, forType: EpilogueCellType)
 }
@@ -37,7 +37,7 @@ class SignupEpilogueCell: UITableViewCell {
     private let passwordTopMargin: CGFloat = 16
 
     private var cellType: EpilogueCellType?
-    open var delegate: SignupEpilogueCellDelegate?
+    open weak var delegate: SignupEpilogueCellDelegate?
 
     // MARK: - UITableViewCell
 

diff --git a/WordPress/Classes/ViewRelated/NUX/SignupEpilogueTableViewController.swift b/WordPress/Classes/ViewRelated/NUX/SignupEpilogueTableViewController.swift
@@ -2,7 +2,7 @@ import UIKit
 import WordPressAuthenticator
 
 
-protocol SignupEpilogueTableViewControllerDelegate {
+protocol SignupEpilogueTableViewControllerDelegate: AnyObject {
     func displayNameUpdated(newDisplayName: String)
     func displayNameAutoGenerated(newDisplayName: String)
     func passwordUpdated(newPassword: String)
@@ -11,7 +11,7 @@ protocol SignupEpilogueTableViewControllerDelegate {
 
 /// Data source to get the temporary user info, not yet saved in the user account.
 ///
-protocol SignupEpilogueTableViewControllerDataSource {
+protocol SignupEpilogueTableViewControllerDataSource: AnyObject {
     var customDisplayName: String? { get }
     var password: String? { get }
     var username: String? { get }
@@ -21,8 +21,8 @@ class SignupEpilogueTableViewController: UITableViewController, EpilogueUserInfo
 
     // MARK: - Properties
 
-    open var dataSource: SignupEpilogueTableViewControllerDataSource?
-    open var delegate: SignupEpilogueTableViewControllerDelegate?
+    open weak var dataSource: SignupEpilogueTableViewControllerDataSource?
+    open weak var delegate: SignupEpilogueTableViewControllerDelegate?
     open var credentials: AuthenticatorCredentials?
     open var socialService: SocialService?
 

diff --git a/WordPress/Classes/ViewRelated/NUX/SignupUsernameTableViewController.swift b/WordPress/Classes/ViewRelated/NUX/SignupUsernameTableViewController.swift
@@ -4,7 +4,7 @@ import WordPressAuthenticator
 class SignupUsernameTableViewController: UITableViewController, SearchTableViewCellDelegate {
     open var currentUsername: String?
     open var displayName: String?
-    open var delegate: SignupUsernameViewControllerDelegate?
+    open weak var delegate: SignupUsernameViewControllerDelegate?
     open var suggestions: [String] = []
     private var service: AccountSettingsService?
     private var isSearching: Bool = false

diff --git a/WordPress/Classes/ViewRelated/NUX/SignupUsernameViewController.swift b/WordPress/Classes/ViewRelated/NUX/SignupUsernameViewController.swift
@@ -2,7 +2,7 @@ import SVProgressHUD
 import WordPressAuthenticator
 
 
-protocol SignupUsernameViewControllerDelegate {
+protocol SignupUsernameViewControllerDelegate: AnyObject {
     func usernameSelected(_ username: String)
 }
 
@@ -12,7 +12,7 @@ class SignupUsernameViewController: UIViewController {
 
     open var currentUsername: String?
     open var displayName: String?
-    open var delegate: SignupUsernameViewControllerDelegate?
+    open weak var delegate: SignupUsernameViewControllerDelegate?
     private var usernamesTableViewController: SignupUsernameTableViewController?
 
     // MARK: - View