Merge pull request #21068 from wordpress-mobile/enable-weak-delegate-…

…rule Enable the weak_delegate SwiftLint rule
wordpress-mobile · Jul 19, 2023 · 01a59f7 · 01a59f7
2 parents 1851fa4 + e662c7c
commit 01a59f7
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 0 deletions.
diff --git a/.swiftlint.yml b/.swiftlint.yml
@@ -3,6 +3,10 @@ remote_timeout: 10.0
 
 opt_in_rules:
   - overridden_super_call
+  - weak_delegate
 
 overridden_super_call:
   severity: error
+
+weak_delegate:
+  severity: error
diff --git a/WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift b/WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
@@ -241,6 +241,7 @@ class GutenbergViewController: UIViewController, PostEditor, FeaturedImageDelega
 
     let navigationBarManager: PostEditorNavigationBarManager
 
+    // swiftlint:disable:next weak_delegate
     lazy var attachmentDelegate = AztecAttachmentDelegate(post: post)
 
     lazy var mediaPickerHelper: GutenbergMediaPickerHelper = {

diff --git a/WordPress/Classes/ViewRelated/Media/MediaItemViewController.swift b/WordPress/Classes/ViewRelated/Media/MediaItemViewController.swift
@@ -13,6 +13,7 @@ class MediaItemViewController: UITableViewController {
 
     }
 
+    // swiftlint:disable:next weak_delegate
     let delegate = DownloadDelegate()
 
     @objc let media: Media

diff --git a/WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailViewController.swift b/WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailViewController.swift
@@ -45,6 +45,8 @@ class ReaderDetailViewController: UIViewController, ReaderDetailView {
 
     /// The table view that displays Comments
     @IBOutlet weak var commentsTableView: IntrinsicTableView!
+
+    // swiftlint:disable:next weak_delegate
     private let commentsTableViewDelegate = ReaderDetailCommentsTableViewDelegate()
 
     /// The table view that displays Related Posts

diff --git a/WordPress/Classes/ViewRelated/Themes/ThemeBrowserViewController.swift b/WordPress/Classes/ViewRelated/Themes/ThemeBrowserViewController.swift
@@ -98,6 +98,7 @@ public protocol ThemePresenter: AnyObject {
 
     @IBOutlet weak var collectionView: UICollectionView!
 
+    // swiftlint:disable:next weak_delegate
     fileprivate lazy var customizerNavigationDelegate: ThemeWebNavigationDelegate = {
         return ThemeWebNavigationDelegate()
     }()

diff --git a/WordPress/WordPressTest/Dashboard/BlazeCampaignsStreamTests.swift b/WordPress/WordPressTest/Dashboard/BlazeCampaignsStreamTests.swift
@@ -6,6 +6,7 @@ import WordPressKit
 final class BlazeCampaignsStreamTests: CoreDataTestCase {
     private var sut: BlazeCampaignsStream!
     private var blog: Blog!
+    // swiftlint:disable:next weak_delegate
     private var delegate = MockCampaignsStreamDelegate()
     private let service = MockBlazePaginatedService()
 

diff --git a/WordPress/WordPressTest/Mention/SuggestionTableViewTests.swift b/WordPress/WordPressTest/Mention/SuggestionTableViewTests.swift
@@ -6,6 +6,7 @@ import XCTest
 final class SuggestionTableViewTests: CoreDataTestCase {
 
     private var view: SuggestionsTableView!
+    // swiftlint:disable:next weak_delegate
     private var delegate: SuggestionsTableViewDelegateMock!
     private var viewModel: SuggestionsListViewModelType {
         return view.viewModel

diff --git a/WordPress/WordPressTest/ReferrerDetailsViewModelTests.swift b/WordPress/WordPressTest/ReferrerDetailsViewModelTests.swift
@@ -3,6 +3,7 @@ import XCTest
 
 class ReferrerDetailsViewModelTests: XCTestCase {
     private var sut: ReferrerDetailsViewModel!
+    // swiftlint:disable:next weak_delegate
     private var spyDelegate: ViewModelDelegateSpy!
 
     override func setUpWithError() throws {
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,6 +13,7 @@ class MediaItemViewController: UITableViewController { @@
         }
+        // swiftlint:disable:next weak_delegate
         let delegate = DownloadDelegate()
         @objc let media: Media
@@ Expand Down @@