-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the login mode before exiting when already logged in (25.7) #21695
Check the login mode before exiting when already logged in (25.7) #21695
Conversation
Generated by 🚫 Danger |
|
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21695-8738e60 | |
Commit | 8738e60 | |
Direct Download | wordpress-prototype-build-pr21695-8738e60.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21695-8738e60 | |
Commit | 8738e60 | |
Direct Download | jetpack-prototype-build-pr21695-8738e60.apk |
This worked well for me – I tested:
on both WP and JP. One thing I noticed (which might be pre-existing). If I sign into a self-hosted site first on WordPress, I can't sign into WordPress.com later because the "Me" tab is gone. Might just be something to look at later. Semi-related, I think the only way to remove a site from the app is to go to the site list and long-press the list item? If so, we should probably have a big "Disconnect Site" button under "Site Settings" |
Interesting - glad you noticed this. I filed this issue for it.
Yes, that really is buried. Issue filed here. |
* Check the login mode before exiting when already logged in (#21695) * Manually bump version number for 25.7-rc-2 * Update translations * Update WordPress metadata translations for 25.7 --------- Co-authored-by: Nick Bradbury <[email protected]>
Fixes #21694
Note: This targets the
release/25.7
branch.The problem was caused by always exiting the login screen when the user is already logged in. There are cases where the login screen is shown even when logged in, in this situation when adding a self-hosted site from the site picker.
Test A:
Test B:
It's recommended to run each test in both WPAndroid and JPAndroid.