Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Fix Non-Transitive Resources #18733

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Jul 4, 2023

This PR fixes some non-transitive resources related build errors for Material R classes on WPSwitch and WPSwitchCompat classes.

FYI: This issue relates to this #18721 compose switch PR (cc @thomashorta), which got merged before this #18707 main non-transitive resources PR, and thus was still using transitive resources for Material related R classes.


To test:

  1. There is nothing much to test here.
  2. Verifying that all the CI checks are successful should be enough.
  3. However, if you want to be thorough about reviewing this change, you use the test instructions with this [Compose] Make Compose and View-based switch visually identical #18721 to verify that both, the WPSwitch and WPSwitchCompat classes, are still working as expected.

Regression Notes

  1. Potential unintended areas of impact

    • Potential breakage or misbehaviour of screens that use these two classes (WPSwitch and WPSwitchCompat).
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To test section above.
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

This related to the below compose switch PR, which got merged before the
main non-transitive resources PR below, and thus still using transitive
resources for 'Material' related R classes.

- Compose Switch PR: https://github.com/wordpress-mobile/
WordPress-Android/pull/18721
- Non-Transitive Resources PR: https://github.com/wordpress-mobile/
WordPress-Android/pull/18707
@ParaskP7 ParaskP7 added this to the Future milestone Jul 4, 2023
@ParaskP7 ParaskP7 requested a review from AjeshRPai July 4, 2023 08:26
@ParaskP7 ParaskP7 self-assigned this Jul 4, 2023
@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18733-addb9e3
Commitaddb9e3
Direct Downloadwordpress-prototype-build-pr18733-addb9e3.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18733-addb9e3
Commitaddb9e3
Direct Downloadjetpack-prototype-build-pr18733-addb9e3.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 . Thanks for fixing this quickly

@AjeshRPai AjeshRPai merged commit 51879d5 into trunk Jul 4, 2023
@AjeshRPai AjeshRPai deleted the build/fix-non-transitive-resources branch July 4, 2023 09:43
@ParaskP7
Copy link
Contributor Author

ParaskP7 commented Jul 4, 2023

You rock @AjeshRPai , thank you for the quick review! 🙇 ❤️ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants