Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses lint issues in AGP 7.2.1 update #16839

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Addresses lint issues in AGP 7.2.1 update #16839

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84598d0
Removes unused TextDrawable widget
oguzkocer Jun 29, 2022
d1eeb1e
Use DividerItemDecoration instead of custom divider in people list
oguzkocer Jun 29, 2022
9988ff8
Addresses Obsolete SDK_INT version checks
oguzkocer Jun 29, 2022
0e12fd6
Refactor: Replace context with recycler view context for people list
ParaskP7 Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Addresses Obsolete SDK_INT version checks
  • Loading branch information
@oguzkocer
oguzkocer committed Jun 29, 2022
commit 9988ff81ba20abdf20dab20a6701d78fd0336354
2 changes: 0 additions & 2 deletions ...n/java/org/wordpress/android/ui/notifications/services/NotificationsUpdateJobService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.wordpress.android.ui.notifications.services;

import android.annotation.TargetApi;
import android.app.job.JobParameters;
import android.app.job.JobService;
import android.content.Context;
Expand All @@ -20,7 +19,6 @@ protected void attachBaseContext(Context newBase) {
super.attachBaseContext(LocaleManager.setLocale(newBase));
}

@TargetApi(22)
@Override
public boolean onStartJob(JobParameters params) {
String noteId = null;
Expand Down
2 changes: 0 additions & 2 deletions ...ain/java/org/wordpress/android/util/analytics/service/InstallationReferrerJobService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.wordpress.android.util.analytics.service;

import android.annotation.TargetApi;
import android.app.job.JobParameters;
import android.app.job.JobService;
import android.os.Bundle;
Expand All @@ -19,7 +18,6 @@
* https://developer.android.com/guide/components/broadcasts.html#receiving_broadcasts
* https://developer.android.com/guide/components/broadcasts#effects-on-process-state
*/
@TargetApi(21)
public class InstallationReferrerJobService extends JobService implements
InstallationReferrerServiceLogic.ServiceCompletionListener {
@Override
Expand Down
3 changes: 1 addition & 2 deletions WordPress/src/main/res/layout/activity_log_list_activity.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
android:scrollIndicators="none"
android:visibility="gone"
app:layout_scrollFlags="noScroll"
android:scrollbars="none"
tools:targetApi="m">
android:scrollbars="none">

<LinearLayout
android:layout_width="wrap_content"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/src/main/res/values-night/styles_zendesk.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<item name="toolbarNavigationButtonStyle">
@style/Widget.AppCompat.Toolbar.Button.Navigation
</item>
<item name="android:windowLightStatusBar" tools:targetApi="m">false</item>
<item name="android:windowLightStatusBar">false</item>
<item name="android:navigationBarColor">@android:color/black</item>
</style>
</resources>
12 changes: 6 additions & 6 deletions libs/editor/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
<style name="FormatBarButtonTablet" parent="FormatBarButton">
<item name="android:layout_marginRight">@dimen/format_bar_button_margin_tablet</item>
<item name="android:layout_marginLeft">@dimen/format_bar_button_margin_tablet</item>
<item name="android:layout_marginStart" tools:targetApi="jelly_bean_mr1">@dimen/format_bar_button_margin_tablet</item>
<item name="android:layout_marginEnd" tools:targetApi="jelly_bean_mr1">@dimen/format_bar_button_margin_tablet</item>
<item name="android:layout_marginStart">@dimen/format_bar_button_margin_tablet</item>
<item name="android:layout_marginEnd">@dimen/format_bar_button_margin_tablet</item>
</style>

<style name="FormatBarHtmlButton" parent="FormatBarButton">
<item name="android:layout_marginLeft">@dimen/format_bar_html_button_left_margin</item>
<item name="android:layout_marginStart" tools:targetApi="jelly_bean_mr1">@dimen/format_bar_html_button_left_margin</item>
<item name="android:layout_marginStart">@dimen/format_bar_html_button_left_margin</item>
</style>

<style name="Divider">
Expand All @@ -34,15 +34,15 @@
<style name="FormatBarTabletGroup">
<item name="android:layout_marginLeft">@dimen/format_bar_button_group_tablet</item>
<item name="android:layout_marginRight">@dimen/format_bar_button_group_tablet</item>
<item name="android:layout_marginStart" tools:targetApi="jelly_bean_mr1">@dimen/format_bar_button_group_tablet</item>
<item name="android:layout_marginEnd" tools:targetApi="jelly_bean_mr1">@dimen/format_bar_button_group_tablet</item>
<item name="android:layout_marginStart">@dimen/format_bar_button_group_tablet</item>
<item name="android:layout_marginEnd">@dimen/format_bar_button_group_tablet</item>
</style>

<style name="ImageOptionsDialogLabel">
<item name="android:textColor">@color/image_options_label</item>
<item name="android:textStyle">bold</item>
<item name="android:paddingLeft">@dimen/image_settings_dialog_label_indent</item>
<item name="android:paddingStart" tools:targetApi="jelly_bean_mr1">@dimen/image_settings_dialog_label_indent</item>
<item name="android:paddingStart">@dimen/image_settings_dialog_label_indent</item>
<item name="android:layout_marginBottom">@dimen/image_settings_dialog_label_margin_bottom</item>
</style>

Expand Down