Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update media insertion to send caption information. #11670

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Update media insertion to send caption information. #11670

merged 3 commits into from
Apr 20, 2020

Conversation

SergioEstevao
Copy link
Contributor

When using the block editor Insert captions when selecting a media item of the media library that has a caption defined.

To test:

  • Start the app
  • Start a new post in GB
  • Add an image block
  • Add an image of the WP media library that has a caption defined ( you can define it on the Media section of the site)
  • Check that the image is added and the caption is set

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added Gutenberg Editing and display of Gutenberg blocks. gutenberg-mobile labels Apr 15, 2020
@SergioEstevao SergioEstevao added this to the 14.7 milestone Apr 15, 2020
@SergioEstevao SergioEstevao requested a review from marecar3 April 15, 2020 14:07
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 15, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@SergioEstevao SergioEstevao mentioned this pull request Apr 15, 2020
Merged
2 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 15, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@SergioEstevao SergioEstevao requested a review from maxme April 17, 2020 09:18
maxme
maxme reviewed Apr 17, 2020
View reviewed changes
Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Works fine: https://bia.is/s/jHnd/screencast-Genymotion-2020-04-17_17.33.04.252.webm

Waiting for the PR in the gutenberg repo to be merged.

@maxme maxme self-requested a review April 20, 2020 16:18
@maxme maxme merged commit 1d6c7cf into develop Apr 20, 2020
@maxme maxme deleted the issue/insert_captions_for_media_library branch April 20, 2020 16:19
@cameronvoell cameronvoell restored the issue/insert_captions_for_media_library branch April 20, 2020 22:00
@cameronvoell cameronvoell mentioned this pull request Apr 20, 2020
Merged
@cameronvoell cameronvoell deleted the issue/insert_captions_for_media_library branch January 28, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxme maxme maxme approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
14.7
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @maxme