Merge pull request #4206 from wordpress-mobile/issue/4184-show-passwo…

…rd-field-crash Adding isAdded() check to MagicLinkSignInFragment
wordpress-mobile · Jun 10, 2016 · 568cb9b · 568cb9b
2 parents 8873db8 + 7f01b7a
commit 568cb9b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 13 deletions.
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/accounts/login/MagicLinkSignInActivity.java b/WordPress/src/main/java/org/wordpress/android/ui/accounts/login/MagicLinkSignInActivity.java
@@ -127,6 +127,6 @@ private void slideInFragment(Fragment fragment, boolean shouldAddToBackStack) {
         if (shouldAddToBackStack) {
             fragmentTransaction.addToBackStack(null);
         }
-        fragmentTransaction.commit();
+        fragmentTransaction.commitAllowingStateLoss();
     }
 }
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/accounts/login/MagicLinkSignInFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/accounts/login/MagicLinkSignInFragment.java
@@ -26,6 +26,7 @@
 import org.wordpress.android.ui.accounts.SignInFragment;
 import org.wordpress.android.ui.main.WPMainActivity;
 import org.wordpress.android.ui.notifications.utils.SimperiumUtils;
+import org.wordpress.android.util.AppLog;
 import org.wordpress.android.util.EditTextUtils;
 
 import java.util.HashMap;
@@ -185,19 +186,23 @@ private void configureMagicLinkUI() {
     }
 
     private void showPasswordFieldAndFocus() {
-        endProgress();
-        showPasswordField();
-        mPasswordEditText.requestFocus();
-        mSignInButton.setText(getString(R.string.sign_in));
-        InputMethodManager imm = (InputMethodManager) getActivity().getSystemService(Activity.INPUT_METHOD_SERVICE);
-        imm.showSoftInput(mPasswordEditText, InputMethodManager.SHOW_IMPLICIT);
+        if (isAdded()) {
+            endProgress();
+            showPasswordField();
+            mPasswordEditText.requestFocus();
+            mSignInButton.setText(getString(R.string.sign_in));
+            InputMethodManager imm = (InputMethodManager) getActivity().getSystemService(Activity.INPUT_METHOD_SERVICE);
+            imm.showSoftInput(mPasswordEditText, InputMethodManager.SHOW_IMPLICIT);
+        }
     }
 
     private void showPasswordField() {
-        mPasswordLayout.setVisibility(View.VISIBLE);
-        mForgotPassword.setVisibility(View.VISIBLE);
-        if (!mSelfHosted) {
-            mPasswordEditText.setImeOptions(EditorInfo.IME_ACTION_DONE);
+        if (isAdded()) {
+            mPasswordLayout.setVisibility(View.VISIBLE);
+            mForgotPassword.setVisibility(View.VISIBLE);
+            if (!mSelfHosted) {
+                mPasswordEditText.setImeOptions(EditorInfo.IME_ACTION_DONE);
+            }
         }
     }
 
@@ -212,8 +217,8 @@ public void onResponse(JSONObject response) {
                     } else {
                         showPasswordFieldAndFocus();
                     }
-                } catch (JSONException e) {
-                    e.printStackTrace();
+                } catch (JSONException error) {
+                    AppLog.e(AppLog.T.MAIN, error);
                     showPasswordFieldAndFocus();
                 }
             }