Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checksums and GPG signatures, support older glibc #99

Merged
merged 8 commits into from
Oct 30, 2023

Conversation

briandefiant
Copy link
Contributor

This PR changes how we generate checksums and GPG signatures for release assets. The only signature generated is now for the checksums file. Installation instructions have been updated to reflect this.

The PR also includes some changes to the build process.

The standalone executable build with pyinstaller now runs on an Ubuntu 18.04 container in order to support systems with older glibc versions. Basic usage of the standalone executable was verified on Ubuntu 18.04, Ubuntu 20.04, Ubuntu 22.04, and RHEL 9.2. The minimum required version of the Python packaging module was reduced to 21.0 in order for the build to work on Ubuntu 18.04.

The deb package is built largely the same. It has only been successfully tested on Ubuntu 20.04 and Ubuntu 22.04. It does not work on Ubuntu 18.04 because Python 3.8 is provided as the python3.8 package (instead of python3) and the deb package dependencies do not know how to handle this. Someone else has a similar issue on StackOverflow, with no resolution. We can revisit this if we need to support 18.04 with the deb package.

@briandefiant
Copy link
Contributor Author

briandefiant commented Oct 27, 2023

This may address #26 as well (though I'm not positive why). I was able to run the standalone executable on RHEL 9.2.

Edit: This addresses the referenced issue because we're now forcing pip to reinstall build requirements before running pyinstaller, which upgrades the certifi package to a more recent version.

@briandefiant briandefiant linked an issue Oct 27, 2023 that may be closed by this pull request
@briandefiant
Copy link
Contributor Author

briandefiant commented Oct 30, 2023

I've also updated release artifacts to not include version numbers, so in the future we can link to the latest downloads with links like:

@akenion akenion merged commit 5329451 into milestone/voodoo-child Oct 30, 2023
@akenion akenion linked an issue Oct 31, 2023 that may be closed by this pull request
@briandefiant briandefiant deleted the gh-98 branch October 31, 2023 14:58
@akenion akenion linked an issue Oct 31, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants