Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show parent exceptions when an exception occurs in a child process and debugging is enabled #31

Closed
akenion opened this issue Aug 29, 2023 · 2 comments · Fixed by #35 or #49
Closed

Show parent exceptions when an exception occurs in a child process and debugging is enabled #31

akenion opened this issue Aug 29, 2023 · 2 comments · Fixed by #35 or #49
Assignees
@akenion @dallaskeene
Labels
dev-complete Development work to resolve this issue is complete enhancement New feature or request qa-passed QA has tested and confirmed the fix for this issue subcommand:scan Related to the scan subcommand
Milestone
exploring-elk

Comments

@akenion
Copy link
Contributor

akenion commented Aug 29, 2023

Currently, only the last exception is displayed. The parent exceptions are often necessary for debugging issues and including them in the output would be helpful.
@akenion akenion added enhancement New feature or request triaged subcommand:scan Related to the scan subcommand labels Aug 29, 2023
@akenion akenion added this to the exploring-elk milestone Aug 29, 2023
@akenion akenion self-assigned this Aug 29, 2023
@akenion akenion mentioned this issue Aug 29, 2023
Closed
@akenion akenion removed the triaged label Aug 30, 2023
@akenion
Copy link
Contributor Author

akenion commented Aug 30, 2023

After further analysis, this only impacts exceptions thrown in workers that are passed back to the main process via a queue. This is because serializing an exception using pickle (which the queue does internally) only saves limited information.

@akenion akenion linked a pull request Aug 30, 2023 that will close this issue
Improved exception handling in child processes #35
Merged
@akenion akenion mentioned this issue Aug 30, 2023
Merged
@akenion akenion changed the title Show parent exceptions when an exception occurs during scanning and debugging is enabled Show parent exceptions when an exception occurs in a child process and debugging is enabled Aug 30, 2023
@akenion akenion added the dev-complete Development work to resolve this issue is complete label Aug 30, 2023
@akenion akenion removed a link to a pull request Aug 31, 2023
Improved exception handling in child processes #35
Merged
@akenion akenion linked a pull request Aug 31, 2023 that will close this issue
Improved exception handling in child processes #35
Merged
akenion added a commit that referenced this issue Aug 31, 2023
@akenion
Merge pull request #35 from wordfence/gh-31
3d1f49c 
Improved exception handling in child processes
@akenion akenion mentioned this issue Sep 5, 2023
Merged
@dallaskeene dallaskeene self-assigned this Sep 15, 2023
@dallaskeene
Copy link

Verified debugged child exceptions now show the parent exception as well, to provide more details on an error.

  • checked debugged child exceptions include the parent exception as well, when applicable
  • checked file locator errors
  • checked scan workers errors
  • additionally checked various IO errors

@dallaskeene dallaskeene added the qa-passed QA has tested and confirmed the fix for this issue label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akenion akenion

@dallaskeene dallaskeene

Labels
dev-complete Development work to resolve this issue is complete enhancement New feature or request qa-passed QA has tested and confirmed the fix for this issue subcommand:scan Related to the scan subcommand
Projects
None yet
Milestone
exploring-elk
2 participants
@akenion @dallaskeene