Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1단계 - 자동차 경주] 페드로(류형욱) 미션 제출합니다. #700
[1단계 - 자동차 경주] 페드로(류형욱) 미션 제출합니다. #700
Changes from all commits
1af483a
a9649af
b7fb784
c08faf0
120727d
3a08581
3d5d290
aab85e4
b5de4a8
985d7fb
40b29de
98b6ff2
b996fbd
f2ddecc
21295d5
bbe6946
bc07afb
51d1513
7fad050
09142da
7d3e8fd
b38fdd2
25dde4a
ec092a5
882f1a2
5c4fd7f
78b57f6
395796c
155a10e
adfb397
85b1003
deb6027
2d9da41
117c03e
15e7ea7
1250237
9295c4d
bdf228b
91e1b2c
0f96d10
1c30133
6481876
2053c2f
b430a92
77a8224
d934a27
522a095
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
페드로는
OutputView
와InputView
를 어떤 기준으로 분리하셨나요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
단순히 콘솔에 출력하는 부분은 모두
OutputView
에서, 사용자의 입력을 받아야 하는 부분은InputView
에서 담당하는 것으로 생각했습니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분이 좋은 힌트가 될 수 있을 것 같아요!
isValid는 어떤걸 의미하나요?
doReadMoveCount는 해당 값을 충족시켜주나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readMoveCount가 아무 값을 반환해주지 않으니
moveCount가 어디 저장되는지 확인하려면 내부 구현을 살펴봐야겠네요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우승자가 없는 경우까지 디테일 하네요ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스트림 사용👍🏻