[Fix] - 메인페이지 modal css 깨짐 및 modal, drawer 애니메이션 적용 안되던 이슈 수정 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results11 tests 11 ✅ 14s ⏱️ Results for commit 4d13007. ♻️ This comment has been updated with latest results. |
simorimi
approved these changes
Oct 23, 2024
| } | ||
|
|
||
| const useUnmountAnimation = ({ isOpen, animationDuration = 300 }: useUnmountAnimationProps) => { | ||
| const [shouldRender, setShouldRender] = useState(false); |
There was a problem hiding this comment.
should의 경우 테스트 코드에서 주로 사용되는 접두사라네요! boolean 속성의 경우는 is, has, can 정도로 알고있습니다. 해당 부분 수정이 필요해보입니다. isRendered 정도면 적당해 보이는데 어떻게 생각하시나요?
There was a problem hiding this comment.
오 그런게 있군요! 좋네요 수정하겠습니다!
- 페이지 이동할 때 마다 ovelay가 보였다가 안보이는 이슈가 있어서 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
📸 스크린샷
🙈 참고 사항