Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - 여행기 & 여행 계획 등록/수정 페이지 리팩터링 #520

Merged
merged 18 commits into from
Oct 14, 2024
Merged

[Feature] - 여행기 & 여행 계획 등록/수정 페이지 리팩터링 #520

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ab97029
refactor(useTravelogueDays): 여행기 등록 페이지 default export로 변경
jinyoung234 Oct 9, 2024
49a501a
refactor(useTravelogueForm): 여행기 form에 대한 책임을 useTravelogueForm으로 분리
jinyoung234 Oct 9, 2024
1e6eec1
refactor(useMultiImageUpload): 다중 이미지 업로드 로직에 대한 리팩터링
jinyoung234 Oct 9, 2024
3ddfe8d
refactor(TravelogueRegisterPage): 페이지 리팩터링
jinyoung234 Oct 9, 2024
d23a62d
refactor(ThumbnailUpload): fileRef와 click 핸들러를 내부에서 관리하는 것으로 변경
jinyoung234 Oct 10, 2024
a5a7ec8
refactor: 인증된 사용자가 아닌 경우 redirect 시키는 hook 분리
jinyoung234 Oct 10, 2024
7745cd3
refactor: useToggle 훅을 통해 open, close 하도록 변경
jinyoung234 Oct 10, 2024
5d0a22f
refactor(travelTransform): TravelTransformPlace의 타입을 유틸리티 타입으로 개선
jinyoung234 Oct 10, 2024
cf84ef5
refactor(TravelogueRegisterPage): useTravelogueForm 형태 변경
jinyoung234 Oct 10, 2024
ee784f0
refactor(TravelogueEditPage): 여행기 수정 페이지 리팩터링
jinyoung234 Oct 10, 2024
c8ebee0
refactor(TravelPlanRegisterPage): 여행 계획 등록에 대한 책임 분리
jinyoung234 Oct 10, 2024
9045bc3
refactor(TravelPlanRegisterPage): 여행 계획 수정 페이지 리팩터링
jinyoung234 Oct 10, 2024
b44f89f
refactor: useTravelPlanFormState, useTravelogueFormState 폴더구조 변경
jinyoung234 Oct 10, 2024
52dca65
fix(useTravelogueFormState): ci 문제 해결
jinyoung234 Oct 10, 2024
6b28065
refactor: on prefix를 handle prefix로 변경
jinyoung234 Oct 13, 2024
5defe1c
refactor(ThumbnailUpload): 불필요한 제네릭 제거
jinyoung234 Oct 13, 2024
02fc25f
refactor(travelTransform): import 시 type 추가
jinyoung234 Oct 13, 2024
6e85fd3
refactor(ThumbnailUpload): 불필요한 props 개행 제거
jinyoung234 Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions frontend/src/types/domain/travelTransform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import { TravelPlanPlace } from "@type/domain/travelPlan";
import { TraveloguePlace } from "@type/domain/travelogue";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

올만에 type 컨벤션 잡아봅니다ㅎㅎㅎ

import type { TravelPlanPlace } from "@type/domain/travelPlan";
import type { TraveloguePlace } from "@type/domain/travelogue";


export type TravelTransformPlace = Pick<
TravelPlanPlace | TraveloguePlace,
keyof TravelPlanPlace & keyof TraveloguePlace
>;
export type TravelTransformPlace = Extract<TraveloguePlace, TravelPlanPlace>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타스챌린지에서 Extract 봐놓고 쌔까맣게 잊고있었네요
👍👍👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract 재밌네요


export interface TravelTransformDays {
id: string;
Expand Down