Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - 데모데이 피드백 반영(지니) #418

Merged
merged 8 commits into from
Sep 25, 2024
Merged

[Feature] - 데모데이 피드백 반영(지니) #418

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a6f8c4
refactor(GoogleMapView): 코드 리팩터링
jinyoung234 Sep 15, 2024
e3f1afb
chore(package.json): test-e2e:run 스크립트 수정
jinyoung234 Sep 15, 2024
261269e
test(travelPlanRegister): force click으로 변경
jinyoung234 Sep 15, 2024
a8f4826
fix(useTravelPlanDays): todo가 제대로 삭제되지 않는 문제 해결
jinyoung234 Sep 15, 2024
dea5c5b
fix(Input): 모바일 화면에서 확대되는 현상 해결
jinyoung234 Sep 17, 2024
2cf394c
refactor(Calendar): 캘린더 ui에서 지난 날짜에 대한 별도 처리 추가
jinyoung234 Sep 17, 2024
c250cc1
refactor(GoogleMapView): 불필요한 console 제거
jinyoung234 Sep 17, 2024
4c11827
test(travelPlanRegister): 불필요한 only 제거
jinyoung234 Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/hooks/pages/useTravelPlanDays.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export const useTravelPlanDays = (days: TravelTransformPlaces[]) => {
const travelPlanPlace = previousTravelPlanDays[dayIndex]?.places[placeIndex];

if (travelPlanPlace?.todos) {
travelPlanPlace.todos.splice(Number(todoId), 1);
travelPlanPlace.todos = travelPlanPlace.todos.filter((todo) => todo.id !== todoId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그 전 코드로는 왜 제대로 삭제 안됐는지 궁금하네요...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

splice의 경우 todos index에서 1개를 지우는건데 todoId가 숫자값이 아닌 문자열이라서 제거가 안되더라구여 !

}
});
},
Expand Down