[ALL] 프론트엔드 배포 자동화 yml 파일 생성 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwinkr
requested review from
ehBeak,
Yoonkyoungme,
ikjo39,
Largopie,
hw0603,
seokmyungham and
seunghye218
as code owners
hw0603
approved these changes
Aug 12, 2024
seunghye218
reviewed
Aug 12, 2024
| name: momoResources | ||
| path: frontend/dist | ||
|
|
||
| deploy: |
There was a problem hiding this comment.
백엔드 워크플로우 네이밍과 같이 작업 이름을 fe-deploy로 짓는 것은 어떨까요?
|
|
||
| deploy: | ||
| needs: fe-build | ||
| runs-on: self-hosted |
There was a problem hiding this comment.
배포 워크플로우시에 self-hosted를 사용하는 이유가 궁금해요!
There was a problem hiding this comment.
CloudFront 배포 특성 상 S3버킷에 빌드된 결과물(html, js, asset 등)을 업로드하고 CF에서 해당 S3를 '원본(공식번역이 이렇긴한데.. Origin 입니다)' 설정하여 라우팅 해 주는데, IAM 키를 직접 발급할 수 없어서 외부에서 S3 버킷에 접근이 불가능합니다.
저희가 사용하는 EC2에는 IAM Role이 설정돼 있어서 별다른 인증 작업 없이 aws s3 커멘드만으로 버킷 접근이 가능하구요.
There was a problem hiding this comment.
저희 상황에서 CloudFront에 접근하기 위해 사용하는 것이었네요. 좋습니다👍👍
seokmyungham
approved these changes
Aug 13, 2024
ikjo39
approved these changes
Aug 13, 2024
Yoonkyoungme
approved these changes
Aug 13, 2024
Largopie
approved these changes
Aug 13, 2024
| - name: 노드 버젼을 설정해요 :) | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "lts/*" |
There was a problem hiding this comment.
[Q]
나중에 버전이 업데이트 되어도 우리 프로젝트에 영향이 갈 일이 없을까요?
버전을 명시하기 vs lts 버전을 유지하기 어떤 부분이 나을까요? 해리의 의견이 궁금해요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
간단 설명
develop 브랜치에서 시작해서
깃허브 이벤트에는 merge가 존재하지 않으므로, develop 브랜치에 push가 되었을 때 워크 플로우를 실행한다.
깃허브 서버에서 특정 job, run들을 수행하면
ubuntu-latest환경에서 수행한다. 하지만, 깃허브 서버에서는 우아한테크코스 aws에 직접 접근할 수 없기 때문에 우아한테크코스 aws에서 생성한 모모 EC2 인스턴스를self-hosted로 사용해서aws cli로 s3, cloudfront와 싱크를 맞춘다.특이 사항
리뷰 요구사항 (선택)