refactor(service): 태그 생성 및 수정 로직 변경

woowacourse-teams · Aug 5, 2024 · 99b6fd9 · 99b6fd9
1 parent c117e0e
commit 99b6fd9
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/backend/src/main/java/codezap/template/service/TemplateService.java b/backend/src/main/java/codezap/template/service/TemplateService.java
@@ -68,11 +68,14 @@ public Long create(CreateTemplateRequest createTemplateRequest) {
     }
 
     private void createTags(CreateTemplateRequest createTemplateRequest, Template template) {
-        templateTagRepository.saveAll(createTemplateRequest.tags().stream()
-                .map(tagName -> tagRepository.save(new Tag(tagName)))
-                .map(tag -> new TemplateTag(template, tag))
-                .toList()
-        );
+        createTemplateRequest.tags().stream()
+                .filter(tagName -> !tagRepository.existsByName(tagName))
+                .map(Tag::new)
+                .forEach(tagRepository::save);
+
+        createTemplateRequest.tags().stream()
+                .map(tagRepository::findByName)
+                .forEach(tag -> templateTagRepository.save(new TemplateTag(template, tag)));
     }
 
     private void createSnippet(CreateSnippetRequest createSnippetRequest, Template template) {
@@ -150,10 +153,9 @@ private void updateTags(UpdateTemplateRequest updateTemplateRequest, Template te
                 .map(Tag::new)
                 .forEach(tagRepository::save);
 
-        List<Tag> tags = updateTemplateRequest.tags().stream()
+        updateTemplateRequest.tags().stream()
                 .map(tagRepository::findByName)
-                .toList();
-        tags.forEach(tag -> templateTagRepository.save(new TemplateTag(template, tag)));
+                .forEach(tag -> templateTagRepository.save(new TemplateTag(template, tag)));
     }
 
     private void validateSnippetsCount(UpdateTemplateRequest updateTemplateRequest, Template template) {